ext4: drop an always true check
authorAdam Borowski <kilobyte@angband.pl>
Mon, 15 Nov 2021 17:20:20 +0000 (18:20 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 10 Jan 2022 18:25:56 +0000 (13:25 -0500)
EXT_FIRST_INDEX(ptr) is ptr+12, which can't possibly be null; gcc-12
warns about this.

Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20211115172020.57853-1-kilobyte@angband.pl
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents.c

index 299d27d04b2b735989cd050ea89f0af7e45cf592..1077ce7e189fe776fbda6c2fdb882f98f6fed7d8 100644 (file)
@@ -1496,8 +1496,7 @@ static int ext4_ext_search_left(struct inode *inode,
                                EXT4_ERROR_INODE(inode,
                                  "ix (%d) != EXT_FIRST_INDEX (%d) (depth %d)!",
                                  ix != NULL ? le32_to_cpu(ix->ei_block) : 0,
-                                 EXT_FIRST_INDEX(path[depth].p_hdr) != NULL ?
-               le32_to_cpu(EXT_FIRST_INDEX(path[depth].p_hdr)->ei_block) : 0,
+                                 le32_to_cpu(EXT_FIRST_INDEX(path[depth].p_hdr)->ei_block),
                                  depth);
                                return -EFSCORRUPTED;
                        }