usb: musb: fix error return code in da8xx_musb_init()
authorWang Yufen <wangyufen@huawei.com>
Sat, 26 Nov 2022 14:35:32 +0000 (22:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Jan 2023 15:37:00 +0000 (16:37 +0100)
Fix to return a negative error code -ENODEV instead of 0 as before
commit 09721ba6daa1 ("usb: musb: da8xx: Call earlier
clk_prepare_enable()") did.

Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Link: https://lore.kernel.org/r/1669473332-14165-1-git-send-email-wangyufen@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/musb/da8xx.c

index a4e55b0..d47e5c9 100644 (file)
@@ -368,8 +368,10 @@ static int da8xx_musb_init(struct musb *musb)
 
        /* Returns zero if e.g. not clocked */
        rev = musb_readl(reg_base, DA8XX_USB_REVISION_REG);
-       if (!rev)
+       if (!rev) {
+               ret = -ENODEV;
                goto fail;
+       }
 
        musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2);
        if (IS_ERR_OR_NULL(musb->xceiv)) {