Both pointer arguments to memcmp are defined as non-null
and compiler optimizes upon that.
PR-URL: https://github.com/nodejs/node/pull/2544
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
size_t cmp_length = MIN(obj_a_length, obj_b_length);
- int32_t val = memcmp(obj_a_data, obj_b_data, cmp_length);
+ int val = cmp_length > 0 ? memcmp(obj_a_data, obj_b_data, cmp_length) : 0;
// Normalize val to be an integer in the range of [1, -1] since
// implementations of memcmp() can vary by platform.
assert.equal(Buffer.compare(b, d), -1);
assert.equal(Buffer.compare(c, c), 0);
+assert.equal(Buffer.compare(Buffer(0), Buffer(0)), 0);
+assert.equal(Buffer.compare(Buffer(0), Buffer(1)), -1);
+assert.equal(Buffer.compare(Buffer(1), Buffer(0)), 1);
assert.throws(function() {
var b = new Buffer(1);