spi: qcom-qspi: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 1 Sep 2020 15:27:09 +0000 (17:27 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 8 Sep 2020 17:19:28 +0000 (18:19 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200901152713.18629-7-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qcom-qspi.c

index b8857a9..f83755e 100644 (file)
@@ -495,9 +495,8 @@ static int qcom_qspi_probe(struct platform_device *pdev)
 
        ctrl->icc_path_cpu_to_qspi = devm_of_icc_get(dev, "qspi-config");
        if (IS_ERR(ctrl->icc_path_cpu_to_qspi)) {
-               ret = PTR_ERR(ctrl->icc_path_cpu_to_qspi);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "Failed to get cpu path: %d\n", ret);
+               ret = dev_err_probe(dev, PTR_ERR(ctrl->icc_path_cpu_to_qspi),
+                                   "Failed to get cpu path\n");
                goto exit_probe_master_put;
        }
        /* Set BW vote for register access */