Update ExecutorFactory comments (#5844)
author이한종/On-Device Lab(SR)/Engineer/삼성전자 <hanjoung.lee@samsung.com>
Thu, 25 Jul 2019 00:30:17 +0000 (09:30 +0900)
committer오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 <hseok82.oh@samsung.com>
Thu, 25 Jul 2019 00:30:17 +0000 (09:30 +0900)
Update outdated comments in `ExecutorFactory.cc`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
runtimes/neurun/core/src/compiler/ExecutorFactory.cc

index 0f413b2..6bebfbf 100644 (file)
@@ -79,7 +79,10 @@ exec::IExecutor *ExecutorFactory::createLinearExecutor(graph::Graph &graph)
   // because SubTensorAnalyzer assume that insert permutation is already finished
   //    lower: decide backend and insert permutation
   //    fix shapes: prepare codegen to optimization
-  //    finalize: generate tensor using subtensor info, then generate kernels
+  //    generate tensor objects: generate tensor using subtensor info
+  //    generate kernels
+  //    allocate tesor memory
+  //    constant intialization: fill the constants with values
   // Generated SubTensorInfo is in operand(Object)
   // for easy pass SubTensorInfo to plan builder and tensor builder
   linear->accept(SubTensorAnalyzer{graph.operands()});
@@ -143,7 +146,7 @@ exec::IExecutor *ExecutorFactory::createLinearExecutor(graph::Graph &graph)
     kernel_gen->generate(*element.subgraph, execution_builder.get());
   });
 
-  // Allocate Tensor Memory for cl_tensors
+  // Allocate Tensor Memory
   for (auto &tensor_builder : tensor_builders)
   {
     tensor_builder->allocate();
@@ -239,7 +242,6 @@ exec::IExecutor *ExecutorFactory::createDataflowExecutor(graph::Graph &graph, bo
     });
   }
 
-  // TODO Extract this to another file
   class ExecutionBuilder : public IExecutionBuilder
   {
   public: