Disable stack trace preprocessing.

This has to wait until issue 4065 has been fixed.

R=ulan@chromium.org
BUG=v8:2340, v8:4065, chromium:482312
LOG=N

Review URL: https://codereview.chromium.org/1110393002

Cr-Commit-Position: refs/heads/master@{#28175}

diff --git a/src/isolate.cc b/src/isolate.cc
index b43b6c5..88ac792 100644 (file)
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -410,11 +410,7 @@ Handle<Object> Isolate::CaptureSimpleStackTrace(Handle<JSObject> error_object,
   elements->Shrink(cursor);
   Handle<JSArray> result = factory()->NewJSArrayWithElements(elements);
   result->set_length(Smi::FromInt(cursor));
-  // Queue this structured stack trace for preprocessing on GC.
-  Handle<Object> old_weak_list(heap()->weak_stack_trace_list(), this);
-  Handle<WeakFixedArray> new_weak_list =
-      WeakFixedArray::Add(old_weak_list, elements);
-  factory()->set_weak_stack_trace_list(new_weak_list);
+  // TODO(yangguo): Queue this structured stack trace for preprocessing on GC.
   return result;
 }
 

diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index 67086e0..fa8cfff 100644 (file)
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -91,6 +91,9 @@
   # Fails sometimes.
   'test-debug/ProcessDebugMessagesThreaded': [PASS, FLAKY],
 
+  # BUG(2340). Preprocessing stack traces is disabled at the moment.
+  'test-heap/PreprocessStackTrace': [FAIL],
+
   ##############################################################################
   # TurboFan compiler failures.