staging: gasket: page table: remove unnecessary logs
authorTodd Poynor <toddpoynor@google.com>
Sat, 21 Jul 2018 13:35:06 +0000 (06:35 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jul 2018 11:56:46 +0000 (13:56 +0200)
Some error logs in page table handling code could only be hit in
cases of programming errors not expected in the current code base, and
aren't likely to be useful on their own.  Remove these.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/gasket_page_table.c

index f0c4884cb4bc6c90ca7e5e433703a68b86958664..4f2ff770065866941cc881b3dbe604b8b147af79 100644 (file)
@@ -605,10 +605,8 @@ EXPORT_SYMBOL(gasket_page_table_is_dev_addr_bad);
 /* See gasket_page_table.h for description. */
 uint gasket_page_table_max_size(struct gasket_page_table *page_table)
 {
-       if (!page_table) {
-               gasket_nodev_error("Passed a null page table.");
+       if (!page_table)
                return 0;
-       }
        return page_table->config.total_entries;
 }
 EXPORT_SYMBOL(gasket_page_table_max_size);
@@ -616,11 +614,8 @@ EXPORT_SYMBOL(gasket_page_table_max_size);
 /* See gasket_page_table.h for description. */
 uint gasket_page_table_num_entries(struct gasket_page_table *pg_tbl)
 {
-       if (!pg_tbl) {
-               gasket_nodev_error("Passed a null page table.");
+       if (!pg_tbl)
                return 0;
-       }
-
        return pg_tbl->num_simple_entries + pg_tbl->num_extended_entries;
 }
 EXPORT_SYMBOL(gasket_page_table_num_entries);
@@ -628,11 +623,8 @@ EXPORT_SYMBOL(gasket_page_table_num_entries);
 /* See gasket_page_table.h for description. */
 uint gasket_page_table_num_simple_entries(struct gasket_page_table *pg_tbl)
 {
-       if (!pg_tbl) {
-               gasket_nodev_error("Passed a null page table.");
+       if (!pg_tbl)
                return 0;
-       }
-
        return pg_tbl->num_simple_entries;
 }
 EXPORT_SYMBOL(gasket_page_table_num_simple_entries);
@@ -640,11 +632,8 @@ EXPORT_SYMBOL(gasket_page_table_num_simple_entries);
 /* See gasket_page_table.h for description. */
 uint gasket_page_table_num_active_pages(struct gasket_page_table *pg_tbl)
 {
-       if (!pg_tbl) {
-               gasket_nodev_error("Passed a null page table.");
+       if (!pg_tbl)
                return 0;
-       }
-
        return pg_tbl->num_active_pages;
 }
 EXPORT_SYMBOL(gasket_page_table_num_active_pages);
@@ -652,10 +641,8 @@ EXPORT_SYMBOL(gasket_page_table_num_active_pages);
 /* See gasket_page_table.h */
 int gasket_page_table_system_status(struct gasket_page_table *page_table)
 {
-       if (!page_table) {
-               gasket_nodev_error("Passed a null page table.");
+       if (!page_table)
                return GASKET_STATUS_LAMED;
-       }
 
        if (gasket_page_table_num_entries(page_table) == 0) {
                gasket_nodev_debug("Page table size is 0.");