soundwire: intel: Fix uninitialized adev deref
authorVinod Koul <vkoul@kernel.org>
Tue, 7 Aug 2018 06:24:50 +0000 (11:54 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Nov 2019 17:45:22 +0000 (18:45 +0100)
[ Upstream commit e1c815f4b24a305e5bc9eceb541674bf4d02b709 ]

In case of error, we can dereference uninitialized 'adev'

drivers/soundwire/intel_init.c:154 sdw_intel_acpi_cb()
error: uninitialized symbol 'adev'.

Fix that by not using adev for warn print and make it pr_err.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soundwire/intel_init.c

index d1ea6b4..5c8a20d 100644 (file)
@@ -151,7 +151,7 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
        struct acpi_device *adev;
 
        if (acpi_bus_get_device(handle, &adev)) {
-               dev_err(&adev->dev, "Couldn't find ACPI handle\n");
+               pr_err("%s: Couldn't find ACPI handle\n", __func__);
                return AE_NOT_FOUND;
        }