[StreamExecutor] Remove ThenDoHostCallbackForTest -- it's identical to ThenDoHostCall...
authorJustin Lebar <jlebar@google.com>
Fri, 9 Mar 2018 10:16:53 +0000 (02:16 -0800)
committerTensorFlower Gardener <gardener@tensorflow.org>
Fri, 9 Mar 2018 10:20:51 +0000 (02:20 -0800)
The reason this came about is: ThenDoHostCallback was once private, and
ThenDoHostCallbackForTest was public.  Then at some point
ThenDoHostCallback became public, but the *ForTest one was never
removed.

PiperOrigin-RevId: 188459741

tensorflow/stream_executor/stream.cc
tensorflow/stream_executor/stream.h

index 4d852e6..6bbb5f0 100644 (file)
@@ -5020,12 +5020,6 @@ Stream &Stream::ThenTransformTensor(const dnn::BatchDescriptor &input_desc,
   return *this;
 }
 
-Stream &Stream::ThenDoHostCallbackForTest(std::function<void()> callback) {
-  VLOG_CALL(PARAM(callback));
-
-  return ThenDoHostCallback(callback);
-}
-
 Stream &Stream::ThenDoHostCallback(std::function<void()> callback) {
   VLOG_CALL(PARAM(callback));
 
index 8cd0a0d..d7d1131 100644 (file)
@@ -1968,16 +1968,15 @@ class Stream {
   // Entrains onto the stream a callback to the host (from the device).
   // Host callbacks block/occupy the stream just as device functions
   // (execute one at a time, block later stream operations).
+  //
   // Behavior is undefined when synchronizing using OpenCL user events.
   // Behavior is undefined if host callbacks call device routines or insert
   // them into any stream.
+  //
   // On certain platforms, ThenDoHostCallback is expected to have significant
   // negative effects on performance.
   Stream &ThenDoHostCallback(std::function<void()> callback);
 
-  // Identical to ThenDoHostCallback; only exposed for testing purposes.
-  Stream &ThenDoHostCallbackForTest(std::function<void()> callback);
-
   // Returns the StreamExecutor (parent object) associated with this stream.
   StreamExecutor *parent() const {
     CHECK(parent_ != nullptr);