mt76: fix rssi ewma tracking
authorFelix Fietkau <nbd@nbd.name>
Fri, 11 Jan 2019 13:17:30 +0000 (14:17 +0100)
committerFelix Fietkau <nbd@nbd.name>
Thu, 17 Jan 2019 13:50:15 +0000 (14:50 +0100)
The generic EWMA code cannot deal with negative numbers, so convert signal
to a positive number before adding it
Fixes mt76x2 AGC tuning

Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mac80211.c
drivers/net/wireless/mediatek/mt76/util.c

index 226f98f..3b09d45 100644 (file)
@@ -567,7 +567,9 @@ mt76_check_sta(struct mt76_dev *dev, struct sk_buff *skb)
 
        sta = container_of((void *) wcid, struct ieee80211_sta, drv_priv);
 
-       ewma_signal_add(&wcid->rssi, status->signal);
+       if (status->signal <= 0)
+               ewma_signal_add(&wcid->rssi, -status->signal);
+
        wcid->inactive_count = 0;
 
        if (!test_bit(MT_WCID_FLAG_CHECK_PS, &wcid->flags))
index 6242421..69270c1 100644 (file)
@@ -100,7 +100,7 @@ int mt76_get_min_avg_rssi(struct mt76_dev *dev)
 
                        spin_lock(&dev->rx_lock);
                        if (wcid->inactive_count++ < 5)
-                               cur_rssi = ewma_signal_read(&wcid->rssi);
+                               cur_rssi = -ewma_signal_read(&wcid->rssi);
                        else
                                cur_rssi = 0;
                        spin_unlock(&dev->rx_lock);