Fix static analysis issues

- Change type of variables to const auto&

Change-Id: Id500412164b44ac1539f09423a2935a66be2f1d3
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>

diff --git a/src/pkginfo.cc b/src/pkginfo.cc
index 2414dfd..9716bce 100644 (file)
--- a/src/pkginfo.cc
+++ b/src/pkginfo.cc
@@ -276,7 +276,7 @@ int GetRunningAppInfoWithCb(int cmd, uid_t uid, aul_app_info_iter_fn cb,
 Context context;
 
 int GetPkgIdFromDB(int pid, char* buf, int len, uid_t uid) {
-  auto appid = context.GetPreInitAppId();
+  const auto& appid = context.GetPreInitAppId();
   if (appid.empty()) {
     _E("Failed to get pre-initialized appid");
     return -1;
@@ -425,7 +425,7 @@ extern "C" API int aul_app_get_appid_bypid_for_uid(int pid, char* appid,
 
   if (getpid() == pid || getpgid(getpid()) == pid) {
     context.Initialize();
-    auto& preinit_appid = context.GetPreInitAppId();
+    const auto& preinit_appid = context.GetPreInitAppId();
     if (!preinit_appid.empty()) {
       snprintf(appid, len, "%s", preinit_appid.c_str());
       return AUL_R_OK;
@@ -465,7 +465,7 @@ extern "C" API int aul_app_get_pkgid_bypid_for_uid(int pid, char* pkgid,
 
   if (getpid() == pid || getpgid(getpid()) == pid) {
     context.Initialize();
-    auto& preinit_pkgid = context.GetPreInitPkgId();
+    const auto& preinit_pkgid = context.GetPreInitPkgId();
     if (!preinit_pkgid.empty()) {
       snprintf(pkgid, len, "%s", preinit_pkgid.c_str());
       return AUL_R_OK;
@@ -764,7 +764,7 @@ extern "C" API int aul_app_get_appid_bypid_async(pid_t pid,
 
   if (getpid() == pid || getpgid(getpid()) == pid) {
     context.Initialize();
-    auto& preinit_appid = context.GetPreInitAppId();
+    const auto& preinit_appid = context.GetPreInitAppId();
     if (!preinit_appid.empty()) {
       callback(AUL_R_OK, pid, preinit_appid.c_str(), user_data);
       return AUL_R_OK;

diff --git a/tool/aulctl/operation/operation_factory.cc b/tool/aulctl/operation/operation_factory.cc
index 450fd27..b11fd7f 100644 (file)
--- a/tool/aulctl/operation/operation_factory.cc
+++ b/tool/aulctl/operation/operation_factory.cc
@@ -42,7 +42,7 @@ std::unique_ptr<Operation> OperationFactory::CreateOperation(
     if (args.empty())
       return std::make_unique<HelpOperation>();
 
-    auto cmd = std::string(args[0]);
+    const auto& cmd = args[0];
     if (cmd == "list-apps") {
       if (args.size() == 1)
         return std::make_unique<ListAppsOperation>(getuid());