scsi: tcmu: refactor nl dev_cfg attr with new nl helpers

use new netlink events helpers tcmu_netlink_init() and
tcmu_netlink_send() to refactor netlink event attribute
TCMU_ATTR_DEV_CFG(belongs to TCMU_CMD_RECONFIG_DEVICE) which is also
dev_config in configFS.

Signed-off-by: Zhu Lingshan <lszhu@suse.com>
Acked-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index c621364..8149568 100644 (file)
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -2241,6 +2241,27 @@ static ssize_t tcmu_dev_config_show(struct config_item *item, char *page)
        return snprintf(page, PAGE_SIZE, "%s\n", udev->dev_config);
 }
 
+static int tcmu_send_dev_config_event(struct tcmu_dev *udev,
+                                     const char *reconfig_data)
+{
+       struct sk_buff *skb = NULL;
+       void *msg_header = NULL;
+       int ret = 0;
+
+       ret = tcmu_netlink_event_init(udev, TCMU_CMD_RECONFIG_DEVICE,
+                                     &skb, &msg_header);
+       if (ret < 0)
+               return ret;
+       ret = nla_put_string(skb, TCMU_ATTR_DEV_CFG, reconfig_data);
+       if (ret < 0) {
+               nlmsg_free(skb);
+               return ret;
+       }
+       return tcmu_netlink_event_send(udev, TCMU_CMD_RECONFIG_DEVICE,
+                                      &skb, &msg_header);
+}
+
+
 static ssize_t tcmu_dev_config_store(struct config_item *item, const char *page,
                                     size_t count)
 {
@@ -2255,8 +2276,7 @@ static ssize_t tcmu_dev_config_store(struct config_item *item, const char *page,
 
        /* Check if device has been configured before */
        if (tcmu_dev_configured(udev)) {
-               ret = tcmu_netlink_event(udev, TCMU_CMD_RECONFIG_DEVICE,
-                                        TCMU_ATTR_DEV_CFG, page);
+               ret = tcmu_send_dev_config_event(udev, page);
                if (ret) {
                        pr_err("Unable to reconfigure device\n");
                        return ret;