by making use of the syntactical structure of function calls. This avoids display
of syntactically invalid codes in diagnostics.
(`#57081: <https://github.com/llvm/llvm-project/issues/57081>`_)
-- Clang no longer emits inappropriate notes about the loss of ``__unaligned`` qualifier
- on overload resolution, when the actual reason for the failure is loss of other qualifiers.
+- The note emitted when an ``operator==`` was defaulted as deleted used to refer to
+ the lack of a data member's "three-way comparison operator". It now refers correctly
+ to the data member's ``operator==``.
+ (`#63960: <https://github.com/llvm/llvm-project/issues/63960>`_)
- Clang's notes about unconvertible types in overload resolution failure now covers
the source range of parameter declaration of the candidate function declaration.
if (Diagnose == ExplainDeleted) {
S.Diag(Subobj.Loc, diag::note_defaulted_comparison_no_viable_function)
- << FD << (OO == OO_ExclaimEqual) << Subobj.Kind << Subobj.Decl;
+ << FD << (OO == OO_EqualEqual || OO == OO_ExclaimEqual)
+ << Subobj.Kind << Subobj.Decl;
// For a three-way comparison, list both the candidates for the
// original operator and the candidates for the synthesized operator.
friend bool operator==(A &, A &); // expected-note {{would lose const qualifier}}
};
struct B {
- A a; // expected-note {{no viable three-way comparison}}
+ A a; // expected-note {{no viable 'operator=='}}
friend bool operator==(B, B) = default; // ok
friend bool operator==(const B&, const B&) = default; // expected-warning {{deleted}} expected-note{{replace 'default'}}
};
struct Q {
struct X {
friend std::strong_ordering operator<=>(const X&, const X&);
- } x; // expected-note {{no viable three-way comparison}}
+ } x; // expected-note {{no viable 'operator=='}}
// expected-error@+1 {{defaulting the corresponding implicit 'operator==' for this defaulted 'operator<=>' would delete it after its first declaration}}
friend std::strong_ordering operator<=>(const Q&, const Q&) = default;
};
// expected-note@-1 {{defaulted 'operator!=' is implicitly deleted because there is no viable 'operator==' for 'A'}}
};
+struct A2 {
+ struct E {};
+ E e;
+ bool operator==(const A2&) const = default; // expected-warning {{explicitly defaulted equality comparison operator is implicitly deleted}} expected-note{{replace 'default'}}
+ // expected-note@-2 {{defaulted 'operator==' is implicitly deleted because there is no viable 'operator==' for member 'e'}}
+};
+
+
struct Q {};
bool operator!=(Q, Q); // expected-note {{defaulted 'operator!=' is implicitly deleted because this non-rewritten comparison function would be the best match for the comparison}}
struct B {
template<typename T> struct X {
X();
bool operator==(const X&) const = default; // #x expected-note 4{{deleted here}}
- T t; // expected-note 3{{because there is no viable three-way comparison function for member 't'}}
+ T t; // expected-note 3{{because there is no viable 'operator==' for member 't'}}
// expected-note@-1 {{because it would invoke a deleted comparison function for member 't'}}
};
// expected-note@#base {{deleted comparison function for base class 'C'}}
// expected-note@#base {{no viable three-way comparison function for base class 'D1'}}
// expected-note@#base {{three-way comparison cannot be synthesized because there is no viable function for '<' comparison}}
- // expected-note@#base {{no viable three-way comparison function for base class 'D2'}}
+ // expected-note@#base {{no viable 'operator==' for base class 'D2'}}
// expected-note@#base {{three-way comparison cannot be synthesized because there is no viable function for '==' comparison}}
// expected-note@#base {{deleted comparison function for base class 'E'}}
// expected-note@#base {{implied comparison for base class 'F' is ambiguous}}
// expected-note@#arr {{deleted comparison function for member 'arr'}}
// expected-note@#arr {{no viable three-way comparison function for member 'arr'}}
// expected-note@#arr {{three-way comparison cannot be synthesized because there is no viable function for '<' comparison}}
- // expected-note@#arr {{no viable three-way comparison function for member 'arr'}}
+ // expected-note@#arr {{no viable 'operator==' for member 'arr'}}
// expected-note@#arr {{three-way comparison cannot be synthesized because there is no viable function for '==' comparison}}
// expected-note@#arr {{deleted comparison function for member 'arr'}}
// expected-note@#arr {{implied comparison for member 'arr' is ambiguous}}