i40e: program fragmented IPv4 filter input set

When implementing support for IP_USER_FLOW filters, we correctly
programmed a filter for both the non fragmented IPv4/Other filter, as
well as the fragmented IPv4 filters. However, we did not properly
program the input set for fragmented IPv4 PCTYPE. This meant that the
filters would almost certainly not match, unless the user specified all
of the flow types.

Add support to program the fragmented IPv4 filter input set. Since we
always program these filters together, we'll assume that the two input
sets must match, and will thus always program the input sets to the same
value.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 03f7007d025e4b688c3fbb0278622fc1e6cad9e5..69644b621b45d629e87ff4845a73b1f4a21ecab8 100644 (file)
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -3809,6 +3809,16 @@ static int i40e_check_fdir_input_set(struct i40e_vsi *vsi,
 
        i40e_write_fd_input_set(pf, index, new_mask);
 
+       /* IP_USER_FLOW filters match both IPv4/Other and IPv4/Fragmented
+        * frames. If we're programming the input set for IPv4/Other, we also
+        * need to program the IPv4/Fragmented input set. Since we don't have
+        * separate support, we'll always assume and enforce that the two flow
+        * types must have matching input sets.
+        */
+       if (index == I40E_FILTER_PCTYPE_NONF_IPV4_OTHER)
+               i40e_write_fd_input_set(pf, I40E_FILTER_PCTYPE_FRAG_IPV4,
+                                       new_mask);
+
        /* Add the new offset and update table, if necessary */
        if (new_flex_offset) {
                err = i40e_add_flex_offset(&pf->l4_flex_pit_list, src_offset,

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index db611433120aa1bba15a56ab564075da8095ec6e..25087e21a0515e44db544f3afffaeb5c0d8c1bfa 100644 (file)
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -7680,6 +7680,9 @@ static void i40e_fdir_filter_exit(struct i40e_pf *pf)
        /* Reprogram the default input set for Other/IPv4 */
        i40e_write_fd_input_set(pf, I40E_FILTER_PCTYPE_NONF_IPV4_OTHER,
                                I40E_L3_SRC_MASK | I40E_L3_DST_MASK);
+
+       i40e_write_fd_input_set(pf, I40E_FILTER_PCTYPE_FRAG_IPV4,
+                               I40E_L3_SRC_MASK | I40E_L3_DST_MASK);
 }
 
 /**