ext4: fix to check return value of freeze_bdev() in ext4_shutdown()

commit c4d13222afd8a64bf11bc7ec68645496ee8b54b9 upstream.

freeze_bdev() can fail due to a lot of reasons, it needs to check its
reason before later process.

Fixes: 783d94854499 ("ext4: add EXT4_IOC_GOINGDOWN ioctl")
Cc: stable@kernel.org
Signed-off-by: Chao Yu <chao@kernel.org>
Link: https://lore.kernel.org/r/20230606073203.1310389-1-chao@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 8c2b1ff5e6959d59e0cca5380a8e144aa9c58a51..3784f70416492be8878573fe2ad0e96b2721068c 100644 (file)
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -800,6 +800,7 @@ static int ext4_shutdown(struct super_block *sb, unsigned long arg)
 {
        struct ext4_sb_info *sbi = EXT4_SB(sb);
        __u32 flags;
+       int ret;
 
        if (!capable(CAP_SYS_ADMIN))
                return -EPERM;
@@ -818,7 +819,9 @@ static int ext4_shutdown(struct super_block *sb, unsigned long arg)
 
        switch (flags) {
        case EXT4_GOING_FLAGS_DEFAULT:
-               freeze_bdev(sb->s_bdev);
+               ret = freeze_bdev(sb->s_bdev);
+               if (ret)
+                       return ret;
                set_bit(EXT4_FLAGS_SHUTDOWN, &sbi->s_ext4_flags);
                thaw_bdev(sb->s_bdev);
                break;