Remove SkPicture SK_SUPPORT_LEGACY_RECORDING_FLAG flag
authorrobertphillips <robertphillips@google.com>
Thu, 12 Jun 2014 19:56:58 +0000 (12:56 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 12 Jun 2014 19:56:58 +0000 (12:56 -0700)
Chromium/Blink should no longer need this flag after:

Chromium: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/322123002/

Blink: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/326953002/

R=mtklein@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/328343002

gyp/skia_for_chromium_defines.gypi
include/core/SkPicture.h

index 30ec290..938893b 100644 (file)
@@ -17,7 +17,6 @@
       'SK_SUPPORT_LEGACY_N32_NAME',
       'SK_SUPPORT_LEGACY_SETCONFIG',
       'SK_IGNORE_ETC1_SUPPORT',
-      'SK_SUPPORT_LEGACY_RECORDING_FLAG',
     ],
   },
 }
index fcedcef..7b38230 100644 (file)
@@ -131,23 +131,6 @@ public:
      */
     void clone(SkPicture* pictures, int count) const;
 
-#ifdef SK_SUPPORT_LEGACY_RECORDING_FLAG
-    // TODO: kUsePathBoundsForClip_RecordingFlag no longer belongs in
-    // SkPicture. It should be moved to SkPictureRecorder (or just made
-    // the default behavior).
-    enum RecordingFlags {
-        /*  This flag specifies that when clipPath() is called, the path will
-            be faithfully recorded, but the recording canvas' current clip will
-            only see the path's bounds. This speeds up the recording process
-            without compromising the fidelity of the playback. The only side-
-            effect for recording is that calling getTotalClip() or related
-            clip-query calls will reflect the path's bounds, not the actual
-            path.
-         */
-        kUsePathBoundsForClip_RecordingFlag = 0x01
-    };
-#endif
-
     /** Replays the drawing commands on the specified canvas.
         @param canvas the canvas receiving the drawing commands.
     */