gstplay: Fix warning parsing API
authorPhilippe Normand <philn@igalia.com>
Mon, 7 Mar 2022 10:14:43 +0000 (10:14 +0000)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Mon, 7 Mar 2022 11:03:41 +0000 (11:03 +0000)
The GError is an out parameter, so should be a ** parameter, like the details
parameter.

See also #1063

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1869>

subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.h

index e03ff3f..ba1322e 100644 (file)
@@ -4676,14 +4676,14 @@ gst_play_message_parse_error (GstMessage * msg, GError ** error,
  * gst_play_message_parse_warning:
  * @msg: A #GstMessage
  * @error: (out) (optional) (transfer full): the resulting warning
- * @details: (out) (optional) (nullable) (transfer full): A GstStructure containing extra details about the error
+ * @details: (out) (optional) (nullable) (transfer full): A #GstStructure containing additional details about the warning
  *
  * Parse the given error @msg and extract the corresponding #GError warning
  *
  * Since: 1.20
  */
 void
-gst_play_message_parse_warning (GstMessage * msg, GError * error,
+gst_play_message_parse_warning (GstMessage * msg, GError ** error,
     GstStructure ** details)
 {
   PARSE_MESSAGE_FIELD (msg, GST_PLAY_MESSAGE_DATA_WARNING, G_TYPE_ERROR, error);
index 0b703e7..9ffc1e1 100644 (file)
@@ -423,7 +423,7 @@ GST_PLAY_API
 void           gst_play_message_parse_error                      (GstMessage *msg, GError **error, GstStructure **details);
 
 GST_PLAY_API
-void           gst_play_message_parse_warning                    (GstMessage *msg, GError *error, GstStructure **details);
+void           gst_play_message_parse_warning                    (GstMessage *msg, GError **error, GstStructure **details);
 
 GST_PLAY_API
 void           gst_play_message_parse_video_dimensions_changed   (GstMessage *msg, guint *width, guint *height);