lib: fix signed/unsigned comparison issues
authorThomas Wood <thomas.wood@intel.com>
Thu, 6 Feb 2014 16:31:54 +0000 (16:31 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 6 Feb 2014 17:32:12 +0000 (18:32 +0100)
Store the result of set_vt_mode as a signed value so that errors can be
caught correctly.

Signed-off-by: Thomas Wood <thomas.wood@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
lib/igt_kms.c

index 3960d24..5f341ff 100644 (file)
@@ -620,15 +620,16 @@ static void restore_vt_mode_at_exit(int sig)
 
 void igt_set_vt_graphics_mode(void)
 {
+       long ret;
+
        igt_install_exit_handler(restore_vt_mode_at_exit);
 
        igt_disable_exit_handler();
-       orig_vt_mode = set_vt_mode(KD_GRAPHICS);
-       if (orig_vt_mode < 0)
-               orig_vt_mode = -1UL;
+       ret = set_vt_mode(KD_GRAPHICS);
        igt_enable_exit_handler();
 
-       igt_assert(orig_vt_mode >= 0);
+       igt_assert(ret >= 0);
+       orig_vt_mode = ret;
 }
 
 int kmstest_get_connector_default_mode(int drm_fd, drmModeConnector *connector,