genirq: Show irq name in non-oneshot error message
authorLuca Ceresoli <luca@lucaceresoli.net>
Tue, 5 Nov 2019 14:08:54 +0000 (15:08 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 9 Jan 2020 14:42:54 +0000 (15:42 +0100)
Requesting a threaded IRQ with handler=NULL and !ONESHOT fails, but the
error message does not include the IRQ line name, which makes it harder to
find the offending driver.

Print the IRQ line name to clarify where the error comes from. Use the same
format as the other pr_err() above in the same function.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20191105140854.27893-1-luca@lucaceresoli.net
kernel/irq/manage.c

index 1753486..b6c53ab 100644 (file)
@@ -1500,8 +1500,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
                 * has. The type flags are unreliable as the
                 * underlying chip implementation can override them.
                 */
-               pr_err("Threaded irq requested with handler=NULL and !ONESHOT for irq %d\n",
-                      irq);
+               pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",
+                      new->name, irq);
                ret = -EINVAL;
                goto out_unlock;
        }