[DAGCombine] Don't use getZExtValue() until we know the constant is in range.
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Wed, 3 Apr 2019 11:00:55 +0000 (11:00 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Wed, 3 Apr 2019 11:00:55 +0000 (11:00 +0000)
Noticed during prep for a patch for PR40758.

llvm-svn: 357571

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

index e58e835..93d5bce 100644 (file)
@@ -6843,8 +6843,8 @@ SDValue DAGCombiner::visitSHL(SDNode *N) {
   if (N1C && N0.getOpcode() == ISD::SRL && N0.hasOneUse() &&
       TLI.shouldFoldShiftPairToMask(N, Level)) {
     if (ConstantSDNode *N0C1 = isConstOrConstSplat(N0.getOperand(1))) {
-      uint64_t c1 = N0C1->getZExtValue();
-      if (c1 < OpSizeInBits) {
+      if (N0C1->getAPIntValue().ult(OpSizeInBits)) {
+        uint64_t c1 = N0C1->getZExtValue();
         uint64_t c2 = N1C->getZExtValue();
         APInt Mask = APInt::getHighBitsSet(OpSizeInBits, OpSizeInBits - c1);
         SDValue Shift;