eth: atlantic: remove a copy of the NAPI_POLL_WEIGHT define
authorJakub Kicinski <kuba@kernel.org>
Thu, 28 Apr 2022 21:23:17 +0000 (14:23 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Apr 2022 10:56:41 +0000 (11:56 +0100)
Defining local versions of NAPI_POLL_WEIGHT with the same
values in the drivers just makes refactoring harder.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/aq_cfg.h
drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
drivers/net/ethernet/aquantia/atlantic/aq_vec.c

index 8bcda2c..7e9c74b 100644 (file)
@@ -65,8 +65,6 @@
  */
 #define AQ_CFG_RESTART_DESC_THRES   (AQ_CFG_SKB_FRAGS_MAX * 2)
 
-#define AQ_CFG_NAPI_WEIGHT     64U
-
 /*#define AQ_CFG_MAC_ADDR_PERMANENT {0x30, 0x0E, 0xE3, 0x12, 0x34, 0x56}*/
 
 #define AQ_CFG_FC_MODE AQ_NIC_FC_FULL
index 06de19f..275324c 100644 (file)
@@ -1218,7 +1218,7 @@ int aq_ptp_init(struct aq_nic_s *aq_nic, unsigned int idx_vec)
        atomic_set(&aq_ptp->offset_ingress, 0);
 
        netif_napi_add(aq_nic_get_ndev(aq_nic), &aq_ptp->napi,
-                      aq_ptp_poll, AQ_CFG_NAPI_WEIGHT);
+                      aq_ptp_poll, NAPI_POLL_WEIGHT);
 
        aq_ptp->idx_vector = idx_vec;
 
index e839e10..f0fdf20 100644 (file)
@@ -120,7 +120,7 @@ struct aq_vec_s *aq_vec_alloc(struct aq_nic_s *aq_nic, unsigned int idx,
        self->rx_rings = 0;
 
        netif_napi_add(aq_nic_get_ndev(aq_nic), &self->napi,
-                      aq_vec_poll, AQ_CFG_NAPI_WEIGHT);
+                      aq_vec_poll, NAPI_POLL_WEIGHT);
 
 err_exit:
        return self;