baseaudiodecoder: Don't take the stream lock in the seek handler
authorSebastian Dröge <sebastian.droege@collabora.co.uk>
Thu, 18 Aug 2011 08:03:20 +0000 (10:03 +0200)
committerSebastian Dröge <sebastian.droege@collabora.co.uk>
Thu, 18 Aug 2011 08:03:20 +0000 (10:03 +0200)
This will lead to deadlocks

omx/gstbaseaudiodecoder.c

index 0aab2c8..f268cbe 100644 (file)
@@ -1509,9 +1509,7 @@ gst_base_audio_decoder_do_seek (GstBaseAudioDecoder * dec, GstEvent * event)
     return FALSE;
   }
 
-  GST_BASE_AUDIO_DECODER_STREAM_LOCK (dec);
   memcpy (&seek_segment, &dec->segment, sizeof (seek_segment));
-  GST_BASE_AUDIO_DECODER_STREAM_UNLOCK (dec);
   gst_segment_set_seek (&seek_segment, rate, format, flags, start_type,
       start_time, end_type, end_time, NULL);
   start_time = seek_segment.last_stop;