pstore: Add prefix to ECC messages
authorVincent Whitchurch <vincent.whitchurch@axis.com>
Tue, 1 Mar 2022 14:49:32 +0000 (15:49 +0100)
committerKees Cook <keescook@chromium.org>
Tue, 1 Mar 2022 18:36:59 +0000 (10:36 -0800)
The "No errors detected" message from the ECC code is shown at the end
of the pstore log and can be confusing or misleading, especially since
it usually appears just after a kernel crash log which normally means
quite the opposite of "no errors".  Prefix the message to clarify that
this message is only about ECC-detected errors.

Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220301144932.89549-1-vincent.whitchurch@axis.com
fs/pstore/ram_core.c

index fe53050..a89e337 100644 (file)
@@ -263,10 +263,10 @@ ssize_t persistent_ram_ecc_string(struct persistent_ram_zone *prz,
 
        if (prz->corrected_bytes || prz->bad_blocks)
                ret = snprintf(str, len, ""
-                       "\n%d Corrected bytes, %d unrecoverable blocks\n",
+                       "\nECC: %d Corrected bytes, %d unrecoverable blocks\n",
                        prz->corrected_bytes, prz->bad_blocks);
        else
-               ret = snprintf(str, len, "\nNo errors detected\n");
+               ret = snprintf(str, len, "\nECC: No errors detected\n");
 
        return ret;
 }