[sanitizer] Intercept initgroups.
authorEvgeniy Stepanov <eugeni.stepanov@gmail.com>
Tue, 22 Oct 2013 12:24:48 +0000 (12:24 +0000)
committerEvgeniy Stepanov <eugeni.stepanov@gmail.com>
Tue, 22 Oct 2013 12:24:48 +0000 (12:24 +0000)
llvm-svn: 193158

compiler-rt/lib/msan/lit_tests/initgroups.cc [new file with mode: 0644]
compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h
compiler-rt/lib/tsan/rtl/tsan_stat.cc
compiler-rt/lib/tsan/rtl/tsan_stat.h

diff --git a/compiler-rt/lib/msan/lit_tests/initgroups.cc b/compiler-rt/lib/msan/lit_tests/initgroups.cc
new file mode 100644 (file)
index 0000000..adba536
--- /dev/null
@@ -0,0 +1,11 @@
+// RUN: %clangxx_msan -m64 -O0 %s -o %t && %t
+
+#include <sys/types.h>
+#include <grp.h>
+
+int main(void) {
+  initgroups("root", 0);
+  // The above fails unless you are root. Does not matter, MSan false positive
+  // (which we are testing for) happens anyway.
+  return 0;
+}
index d8d21b4ee3f4e0041d49817109067c12824a6a95..1b736ade694dc3354c67cffb89906bd9b2d519ef 100644 (file)
@@ -2408,6 +2408,19 @@ INTERCEPTOR(int, fstatvfs64, int fd, void *buf) {
 #define INIT_STATVFS64
 #endif
 
+#if SANITIZER_INTERCEPT_INITGROUPS
+INTERCEPTOR(int, initgroups, char *user, u32 group) {
+  void *ctx;
+  COMMON_INTERCEPTOR_ENTER(ctx, initgroups, user, group);
+  if (user) COMMON_INTERCEPTOR_READ_RANGE(ctx, user, REAL(strlen)(user) + 1);
+  int res = REAL(initgroups)(user, group);
+  return res;
+}
+#define INIT_INITGROUPS INTERCEPT_FUNCTION(initgroups);
+#else
+#define INIT_INITGROUPS
+#endif
+
 #define SANITIZER_COMMON_INTERCEPTORS_INIT \
   INIT_STRCMP;                             \
   INIT_STRNCMP;                            \
@@ -2498,4 +2511,5 @@ INTERCEPTOR(int, fstatvfs64, int fd, void *buf) {
   INIT_STATFS64;                           \
   INIT_STATVFS;                            \
   INIT_STATVFS64;                          \
+  INIT_INITGROUPS;                         \
 /**/
index 312b073b8b8155f2314bcb61348f5e38be070a8a..01bddd2c6c874696718986dcba93ba867464748f 100644 (file)
 # define SANITIZER_INTERCEPT_STATFS64 SI_MAC || SI_LINUX_NOT_ANDROID
 # define SANITIZER_INTERCEPT_STATVFS SI_LINUX_NOT_ANDROID
 # define SANITIZER_INTERCEPT_STATVFS64 SI_LINUX_NOT_ANDROID
+# define SANITIZER_INTERCEPT_INITGROUPS SI_NOT_WINDOWS
 
 # define SANITIZER_INTERCEPT__EXIT SI_LINUX
 
index bc1ce9d034f27ec38048c1fe1c14e71306cbecc6..971e739ce2dd8face41c7a274cf0cc3b41ba8cd9 100644 (file)
@@ -384,6 +384,7 @@ void StatOutput(u64 *stat) {
   name[StatInt_statvfs64]                = "  statvfs64                       ";
   name[StatInt_fstatvfs]                 = "  fstatvfs                        ";
   name[StatInt_fstatvfs64]               = "  fstatvfs64                      ";
+  name[StatInt_initgroups]               = "  initgroups                      ";
 
   name[StatAnnotation]                   = "Dynamic annotations               ";
   name[StatAnnotateHappensBefore]        = "  HappensBefore                   ";
index a3deef85b6ff49a201b07d0f78a347683fe25f12..237a8921e4d6a89ceccf61923f57862805d1b544 100644 (file)
@@ -379,6 +379,7 @@ enum StatType {
   StatInt_statvfs64,
   StatInt_fstatvfs,
   StatInt_fstatvfs64,
+  StatInt_initgroups,
 
   // Dynamic annotations.
   StatAnnotation,