drm/amd/display: fix rotation_angle to use enum values
authorBrandon Syu <Brandon.Syu@amd.com>
Thu, 9 Jan 2020 06:19:20 +0000 (14:19 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 22 Jan 2020 21:55:28 +0000 (16:55 -0500)
[Why]
Hardcoded fixed values are not proper.

[How]
Use enum values instead of fixed numbers.

Signed-off-by: Brandon Syu <Brandon.Syu@amd.com>
Reviewed-by: Eric Yang <eric.yang2@amd.com>
Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hubp.c

index da63fc5..cf09b93 100644 (file)
@@ -261,28 +261,28 @@ static void hubp21_apply_PLAT_54186_wa(
                        address->video_progressive.luma_addr.high_part == 0xf4)
                return;
 
-       if ((rotation_angle == 0 || rotation_angle == 180)
+       if ((rotation_angle == ROTATION_ANGLE_0 || rotation_angle == ROTATION_ANGLE_180)
                        && viewport_c_height <= 512)
                return;
 
-       if ((rotation_angle == 90 || rotation_angle == 270)
+       if ((rotation_angle == ROTATION_ANGLE_90 || rotation_angle == ROTATION_ANGLE_270)
                                && viewport_c_width <= 512)
                return;
 
        switch (rotation_angle) {
-       case 0: /* 0 degree rotation */
+       case ROTATION_ANGLE_0: /* 0 degree rotation */
                row_height = 128;
                patched_viewport_height = (viewport_c_height / row_height + 1) * row_height + 1;
                patched_viewport_width = viewport_c_width;
                hubp21->PLAT_54186_wa_chroma_addr_offset = 0;
                break;
-       case 2: /* 180 degree rotation */
+       case ROTATION_ANGLE_180: /* 180 degree rotation */
                row_height = 128;
                patched_viewport_height = viewport_c_height + row_height;
                patched_viewport_width = viewport_c_width;
                hubp21->PLAT_54186_wa_chroma_addr_offset = 0 - chroma_pitch * row_height * chroma_bpe;
                break;
-       case 1: /* 90 degree rotation */
+       case ROTATION_ANGLE_90: /* 90 degree rotation */
                row_height = 256;
                if (h_mirror_en) {
                        patched_viewport_height = viewport_c_height;
@@ -294,7 +294,7 @@ static void hubp21_apply_PLAT_54186_wa(
                        hubp21->PLAT_54186_wa_chroma_addr_offset = 0 - tile_blk_size;
                }
                break;
-       case 3: /* 270 degree rotation */
+       case ROTATION_ANGLE_270: /* 270 degree rotation */
                row_height = 256;
                if (h_mirror_en) {
                        patched_viewport_height = viewport_c_height;