ASoC: SOF: Intel: hda: Only dump firmware registers for IPC3
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Fri, 23 Sep 2022 13:36:15 +0000 (16:36 +0300)
committerMark Brown <broonie@kernel.org>
Fri, 23 Sep 2022 13:53:21 +0000 (14:53 +0100)
The firmware register dump is IPC3 specific, it is not available for other
IPC versions.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20220923133616.26267-6-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda.c

index ca648d2..e00062f 100644 (file)
@@ -598,7 +598,8 @@ void hda_dsp_dump(struct snd_sof_dev *sdev, u32 flags)
        /* print ROM/FW status */
        hda_dsp_get_state(sdev, level);
 
-       if (flags & SOF_DBG_DUMP_REGS) {
+       /* The firmware register dump only available with IPC3 */
+       if (flags & SOF_DBG_DUMP_REGS && sdev->pdata->ipc_type == SOF_IPC) {
                u32 status = snd_sof_dsp_read(sdev, HDA_DSP_BAR, HDA_DSP_SRAM_REG_FW_STATUS);
                u32 panic = snd_sof_dsp_read(sdev, HDA_DSP_BAR, HDA_DSP_SRAM_REG_FW_TRACEP);