Add -Wno-error=shadow build option

In some different build environment (e.g., product divisions),
several strict compilation options (e.g., -Werror=shadow) are added.
"Shadowing" is intentional and not a bug in sessiond implementation,
so that we avoid the following build errors by adding -Wno-error=shadow.

[   29s] /home/abuild/rpmbuild/BUILD/sessiond-0.1/sessiond/src/main.cpp:133:4: error:
declaration of 'completion_signal' shadows a member of 'wait_manager<Vs>' [-Werror=shadow]
[   29s]   133 |    : session_uid(session_uid), connection(connection), completion_signal(completion_signal) {}
[   29s]       |    ^
[   29s] /home/abuild/rpmbuild/BUILD/sessiond-0.1/sessiond/src/main.cpp:286:19: note: shadowed declaration is here
[   29s]   286 |  std::string_view completion_signal;
[   29s]       |                   ^~~~~~~~~~~~~~~~~

Change-Id: Ie0503dd49d5f5851ec2866a87c420cc44dc3b6ef
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 727ce1bcdbe0c1ab813a5602dd0f81ec00f4159f..3f7ce8ed8b8cc7111a403d351a3609969055e4b3 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -6,8 +6,8 @@ project(sessiond LANGUAGES C CXX)
 set(CMAKE_SHARED_LIBRARY_PREFIX "")
 
 # Needed for ASLR to work
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -fPIE")
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -fPIE")
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -fPIE -Wno-error=shadow")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -fPIE -Wno-error=shadow")
 set(CMAKE_EXE_LINKER_FLAGS "-Wl,--as-needed -pie")
 
 add_subdirectory(libsessiond)