gspawn: Abort if we can't open /dev/null
authorColin Walters <walters@verbum.org>
Thu, 21 Jun 2012 19:37:39 +0000 (15:37 -0400)
committerColin Walters <walters@verbum.org>
Fri, 22 Jun 2012 14:34:03 +0000 (10:34 -0400)
This really "shouldn't happen", but if we have an assertion here, it
will help static analysis tools know we're not hitting undefined
state.

glib/gspawn.c

index bdecff2..5d8d57b 100644 (file)
@@ -1099,6 +1099,7 @@ do_exec (gint                  child_err_report_fd,
     {
       /* Keep process from blocking on a read of stdin */
       gint read_null = open ("/dev/null", O_RDONLY);
+      g_assert (read_null != -1);
       sane_dup2 (read_null, 0);
       close_and_invalidate (&read_null);
     }
@@ -1117,6 +1118,7 @@ do_exec (gint                  child_err_report_fd,
   else if (stdout_to_null)
     {
       gint write_null = sane_open ("/dev/null", O_WRONLY);
+      g_assert (write_null != -1);
       sane_dup2 (write_null, 1);
       close_and_invalidate (&write_null);
     }