ath11k: Fix an error handling path

[ Upstream commit e7bcc145bcd035e56da7b97b033c463b32a5ff80 ]

If 'kzalloc' fails, we must return an error code.

While at it, remove a useless initialization of 'err' which could hide the
issue.

Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201122173943.1366167-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index c2b1651..99a88ca 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -1585,15 +1585,17 @@ static int ath11k_qmi_fw_ind_register_send(struct ath11k_base *ab)
        struct qmi_wlanfw_ind_register_resp_msg_v01 *resp;
        struct qmi_handle *handle = &ab->qmi.handle;
        struct qmi_txn txn;
-       int ret = 0;
+       int ret;
 
        req = kzalloc(sizeof(*req), GFP_KERNEL);
        if (!req)
                return -ENOMEM;
 
        resp = kzalloc(sizeof(*resp), GFP_KERNEL);
-       if (!resp)
+       if (!resp) {
+               ret = -ENOMEM;
                goto resp_out;
+       }
 
        req->client_id_valid = 1;
        req->client_id = QMI_WLANFW_CLIENT_ID;