raid5-cache: hold spinlock instead of mutex in r5c_journal_mode_show
authorGuoqing Jiang <guoqing.jiang@cloud.ionos.com>
Tue, 28 Jul 2020 10:01:42 +0000 (12:01 +0200)
committerSong Liu <songliubraving@fb.com>
Mon, 3 Aug 2020 06:03:52 +0000 (23:03 -0700)
Replace mddev_lock with spin_lock to align with other show methods in
raid5_attrs.

Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
drivers/md/raid5-cache.c

index 82eb4a9..4337ae0 100644 (file)
@@ -2537,13 +2537,10 @@ static ssize_t r5c_journal_mode_show(struct mddev *mddev, char *page)
        struct r5conf *conf;
        int ret;
 
-       ret = mddev_lock(mddev);
-       if (ret)
-               return ret;
-
+       spin_lock(&mddev->lock);
        conf = mddev->private;
        if (!conf || !conf->log) {
-               mddev_unlock(mddev);
+               spin_unlock(&mddev->lock);
                return 0;
        }
 
@@ -2563,7 +2560,7 @@ static ssize_t r5c_journal_mode_show(struct mddev *mddev, char *page)
        default:
                ret = 0;
        }
-       mddev_unlock(mddev);
+       spin_unlock(&mddev->lock);
        return ret;
 }