mac80211_hwsim: add power save support
authorThomas Pedersen <thomas@adapt-ip.com>
Tue, 14 Jan 2020 05:59:39 +0000 (21:59 -0800)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 15 Jan 2020 10:20:04 +0000 (11:20 +0100)
Advertise the correct flags to mac80211 to indicate PS
trigger frames and frame buffering should be handled by
mac80211. This means mac80211_hwsim will now also have to
release buffered multicast frames after a (DTIM) beacon.

Leave STA power save disabled by default since it causes
several p2p, scanning, and rrm hostap tests to fail.

Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
Link: https://lore.kernel.org/r/20200114055940.18502-2-thomas@adapt-ip.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/mac80211_hwsim.c

index 181d216..05464b5 100644 (file)
@@ -1593,6 +1593,11 @@ static void mac80211_hwsim_beacon_tx(void *arg, u8 *mac,
        mac80211_hwsim_tx_frame(hw, skb,
                                rcu_dereference(vif->chanctx_conf)->def.chan);
 
+       while ((skb = ieee80211_get_buffered_bc(hw, vif)) != NULL) {
+               mac80211_hwsim_tx_frame(hw, skb,
+                               rcu_dereference(vif->chanctx_conf)->def.chan);
+       }
+
        if (vif->csa_active && ieee80211_csa_is_complete(vif))
                ieee80211_csa_finish(vif);
 }
@@ -2923,11 +2928,15 @@ static int mac80211_hwsim_new_radio(struct genl_info *info,
        ieee80211_hw_set(hw, MFP_CAPABLE);
        ieee80211_hw_set(hw, SIGNAL_DBM);
        ieee80211_hw_set(hw, SUPPORTS_PS);
+       ieee80211_hw_set(hw, REPORTS_TX_ACK_STATUS);
+       ieee80211_hw_set(hw, HOST_BROADCAST_PS_BUFFERING);
+       ieee80211_hw_set(hw, PS_NULLFUNC_STACK);
        ieee80211_hw_set(hw, TDLS_WIDER_BW);
        if (rctbl)
                ieee80211_hw_set(hw, SUPPORTS_RC_TABLE);
        ieee80211_hw_set(hw, SUPPORTS_MULTI_BSSID);
 
+       hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
        hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_TDLS |
                            WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL |
                            WIPHY_FLAG_AP_UAPSD |