Check coding style 33/214633/1
authormk5004.lee <mk5004.lee@samsung.com>
Wed, 25 Sep 2019 01:44:15 +0000 (10:44 +0900)
committermk5004.lee <mk5004.lee@samsung.com>
Wed, 25 Sep 2019 01:44:15 +0000 (10:44 +0900)
Change-Id: I84c560ab963105c2dbbfce2e4f368c4d41b9fc87
Signed-off-by: mk5004.lee <mk5004.lee@samsung.com>
31 files changed:
notification-ex/abstract_item.cc
notification-ex/abstract_item.h
notification-ex/abstract_item_implementation.h
notification-ex/api/notification_ex_event_info.h
notification-ex/api/notification_ex_manager.h
notification-ex/api/notification_ex_reporter.h
notification-ex/app_control_action.h
notification-ex/common.h
notification-ex/db_manager.cc
notification-ex/db_manager.h
notification-ex/dbus_connection_manager.h
notification-ex/dbus_event_listener.h
notification-ex/dbus_sender.h
notification-ex/event_observer_interface.h
notification-ex/event_sender_interface.h
notification-ex/group_item_implementation.h
notification-ex/ievent_info.h
notification-ex/iitem_factory.h
notification-ex/iitem_info_internal.h
notification-ex/image_item.h
notification-ex/input_selector_item.h
notification-ex/item_inflator.h
notification-ex/item_info_internal.h
notification-ex/manager.h
notification-ex/progress_item.h
notification-ex/progress_item_implementation.h
notification-ex/reporter.h
notification-ex/stub.cc
notification-ex/text_item.h
notification-ex/visibility_action.h
notification-ex/visibility_action_implementation.h

index 375fe0ef7dc08a23509686780e54518f3fcdfd1d..5ab91e95e163e7de6a5e450d6b4f337d34eeb5aa 100644 (file)
@@ -571,7 +571,7 @@ bool AbstractItem::SetMainType(std::string target_id, MainType type) {
   AbstractItem& target = FindByID(target_id);
   if (target.GetType() == NullObject)
     return false;
-  if (!impl_->IsValidMainType(target,type)) {
+  if (!impl_->IsValidMainType(target, type)) {
     LOGE("Main type and item type are not matched (%d, %d)",
         type, target.GetType());
     return false;
index 223ba2a814b6a5921cb4edc8f3e528f3e92db3cc..8c80bb62ce472735c0f5241e209646d19905b2cc 100644 (file)
@@ -23,6 +23,7 @@
 #include <memory>
 #include <string>
 #include <list>
+#include <vector>
 
 #include "notification-ex/abstract_action.h"
 #include "notification-ex/multi_language.h"
index 29dc0bdbfc48254ae06e2531f124a97ce8583ee8..f943a0c7b2d952dd7e7757407e0cd30c99cc6e94 100644 (file)
@@ -20,6 +20,7 @@
 #include <string>
 #include <memory>
 #include <list>
+#include <vector>
 
 #include "notification-ex/abstract_item.h"
 
index 59f9139f7b2a36b311278cd3cad0bfa170692f34..f0fed1b7f232bdf23d4a908a0ecba4aa1ffc68f5 100644 (file)
@@ -43,7 +43,7 @@ typedef enum _noti_ex_event_info_type {
  * @brief The handle for the notification event information.
  * @since_tizen 5.5
  */
-typedef voidnoti_ex_event_info_h;
+typedef void *noti_ex_event_info_h;
 
 /**
  * @brief Clones the notification event info handle.
index f72d4849cad60cc15ca93663b47255396584c41c..5039fc14abdd3351144f3e07afc960b7da39faf5 100644 (file)
@@ -34,7 +34,7 @@ extern "C" {
  * @brief The notification_ex manager handle.
  * @since_tizen 5.5
  */
-typedef voidnoti_ex_manager_h;
+typedef void *noti_ex_manager_h;
 
 /**
  * @brief Called when a notification addition event is received.
index 12835e8e3df28f010b7d3263b868e664d8a15fee..f0fb4012c17a45d3c9e16f04376a12956759eda0 100644 (file)
@@ -34,7 +34,7 @@ extern "C" {
  * @brief The notification_ex reporter handle.
  * @since_tizen 5.5
  */
-typedef voidnoti_ex_reporter_h;
+typedef void *noti_ex_reporter_h;
 
 /**
  * @brief Called when the error event is received.
index efb8d70cc8b77c1eb747e14db241df54db2de8b8..d32985c9fa3d668c1f7125aa710819c16626cd22 100644 (file)
@@ -19,6 +19,8 @@
 
 #include <app_control.h>
 
+#include <string>
+
 #include "notification-ex/abstract_action.h"
 
 namespace notification {
index 72b4677d80bb0afd3280b9fdb8169b411429d1f6..74cebbdafec46a43ebcbc948ee0462ba447c8f61 100644 (file)
 namespace notification {
 
 enum NotificationError {
- ERROR_NONE = TIZEN_ERROR_NONE, /**< Success */
- ERROR_INVALID_PARAMETER = TIZEN_ERROR_INVALID_PARAMETER, /**< Invalid parameter */
- ERROR_OUT_OF_MEMORY = TIZEN_ERROR_OUT_OF_MEMORY, /**< Out of memory */
- ERROR_IO_ERROR = TIZEN_ERROR_IO_ERROR, /**< I/O error */
- ERROR_PERMISSION_DENIED = TIZEN_ERROR_PERMISSION_DENIED, /**< Permission denied */
- ERROR_INVALID_OPERATION = TIZEN_ERROR_INVALID_OPERATION, /**< Function not implemented (@b Since: @if MOBILE 2.4 @elseif WEARABLE 3.0 @endif) */
- ERROR_FROM_DB = TIZEN_ERROR_NOTIFICATION | 0x01, /**< Error from DB query */
- ERROR_ALREADY_EXIST_ID = TIZEN_ERROR_NOTIFICATION | 0x02, /**< Already exist private ID */
- ERROR_FROM_DBUS = TIZEN_ERROR_NOTIFICATION | 0x03, /**< Error from DBus */
- ERROR_NOT_EXIST_ID = TIZEN_ERROR_NOTIFICATION | 0x04, /**< Not exist private ID */
- ERROR_SERVICE_NOT_READY = TIZEN_ERROR_NOTIFICATION | 0x05, /**< No response from notification service */
- ERROR_MAX_EXCEEDED = TIZEN_ERROR_NOTIFICATION | 0x06, /**< Max notification count exceeded (@b Since: 3.0) */
 ERROR_NONE = TIZEN_ERROR_NONE, /**< Success */
 ERROR_INVALID_PARAMETER = TIZEN_ERROR_INVALID_PARAMETER, /**< Invalid parameter */
 ERROR_OUT_OF_MEMORY = TIZEN_ERROR_OUT_OF_MEMORY, /**< Out of memory */
 ERROR_IO_ERROR = TIZEN_ERROR_IO_ERROR, /**< I/O error */
 ERROR_PERMISSION_DENIED = TIZEN_ERROR_PERMISSION_DENIED, /**< Permission denied */
 ERROR_INVALID_OPERATION = TIZEN_ERROR_INVALID_OPERATION, /**< Function not implemented (@b Since: @if MOBILE 2.4 @elseif WEARABLE 3.0 @endif) */
 ERROR_FROM_DB = TIZEN_ERROR_NOTIFICATION | 0x01, /**< Error from DB query */
 ERROR_ALREADY_EXIST_ID = TIZEN_ERROR_NOTIFICATION | 0x02, /**< Already exist private ID */
 ERROR_FROM_DBUS = TIZEN_ERROR_NOTIFICATION | 0x03, /**< Error from DBus */
 ERROR_NOT_EXIST_ID = TIZEN_ERROR_NOTIFICATION | 0x04, /**< Not exist private ID */
 ERROR_SERVICE_NOT_READY = TIZEN_ERROR_NOTIFICATION | 0x05, /**< No response from notification service */
 ERROR_MAX_EXCEEDED = TIZEN_ERROR_NOTIFICATION | 0x06, /**< Max notification count exceeded (@b Since: 3.0) */
 };
 
 }  // namespace notification
index e36c38734682cb920ffa9721db2de1aff2e82a69..6652afff8970a23167f55c9ec3ca8bd223ebdab3 100644 (file)
@@ -413,7 +413,7 @@ int DBManager::InsertNotification(list<shared_ptr<item::AbstractItem>> addedItem
           uid,
           i->GetChannel().c_str(),
           util::GetQuarkFromString(i->GetId() + to_string(uid)),
-          GetPkgId(i->GetSenderAppId(),uid).c_str(),
+          GetPkgId(i->GetSenderAppId(), uid).c_str(),
           static_cast<int>(i->GetPolicy()),
           reinterpret_cast<char*>(b.ToRaw().first.get()),
           static_pointer_cast<IItemInfo>(i->GetInfo())->GetTime());
index f2751ada05b3fd66f6730635c1b54e6533522920..51d7e5daf6373e2028c8ca07ba5d5de4e477188f 100644 (file)
@@ -60,8 +60,7 @@ class EXPORT_API DBManager {
   static void CheckLimit(std::shared_ptr<item::AbstractItem> addedItem, sqlite3* db);
   static int UpdateReceiverList(std::shared_ptr<item::AbstractItem> updatedItem,  sqlite3* db);
   static std::list<std::shared_ptr<item::AbstractItem>> ExecuteGetList(char* query);
-
 };
 }  // namespace notification
 
-#endif  // NOTIFICATION_EX_DB_MANAGER_H_
\ No newline at end of file
+#endif  // NOTIFICATION_EX_DB_MANAGER_H_
index 995d0453176233fd390145e717596c43ff354b49..1f967585da161bb83ff0c24fc4ea6e84abf3fe4b 100644 (file)
@@ -14,8 +14,8 @@
  * limitations under the License.
  */
 
-#ifndef NOTIFICATION_EX_DBUS_MANAGER_H_
-#define NOTIFICATION_EX_DBUS_MANAGER_H_
+#ifndef NOTIFICATION_EX_DBUS_CONNECTION_MANAGER_H_
+#define NOTIFICATION_EX_DBUS_CONNECTION_MANAGER_H_
 
 #include <gio/gio.h>
 
@@ -47,4 +47,4 @@ class EXPORT_API DBusConnectionManager {
 
 }  // namespace notification
 
-#endif  // NOTIFICATION_EX_DBUS_MANAGER_H_
+#endif  // NOTIFICATION_EX_DBUS_CONNECTION_MANAGER_H_
index 9e8b3a5833d63621405a5c6fa6c5a0133905ef84..1daef17673bcbd1d0c79b45536901a48dc5d3dad 100644 (file)
  * limitations under the License.
  */
 
-#ifndef NOTIFICATION_EX_DBUS_LISTENER_H_
-#define NOTIFICATION_EX_DBUS_LISTENER_H_
+#ifndef NOTIFICATION_EX_DBUS_EVENT_LISTENER_H_
+#define NOTIFICATION_EX_DBUS_EVENT_LISTENER_H_
+
+#include <string>
+#include <list>
 
 #include "notification-ex/event_listener_interface.h"
 
@@ -40,4 +43,4 @@ class EXPORT_API DBusEventListener : public IEventListener {
 
 }  // namespace notification
 
-#endif  // NOTIFICATION_EX_DBUS_LISTENER_H_
+#endif  // NOTIFICATION_EX_DBUS_EVENT_LISTENER_H_
index 4626e26900c48e3926d44a97a5369778814a6da4..8f95d25f93e6e31e83f989f9dd6e17fbcdb2a3e9 100644 (file)
@@ -19,6 +19,9 @@
 
 #include <bundle_cpp.h>
 
+#include <string>
+#include <list>
+
 #include "notification-ex/event_sender_interface.h"
 #include "notification-ex/ievent_info.h"
 
index 66276526cf040ca1ba215f8b1bcc7f771e413bd2..bad3a23183fc5174c63799e3ef98c5d136af8c10 100644 (file)
@@ -14,8 +14,8 @@
  * limitations under the License.
  */
 
-#ifndef NOTIFICATION_EX_OBSERVER_INTERFACE_H_
-#define NOTIFICATION_EX_OBSERVER_INTERFACE_H_
+#ifndef NOTIFICATION_EX_EVENT_OBSERVER_INTERFACE_H_
+#define NOTIFICATION_EX_EVENT_OBSERVER_INTERFACE_H_
 
 #include <bundle_cpp.h>
 
@@ -40,4 +40,4 @@ class EXPORT_API IEventObserver {
 
 }  // namespace notification
 
-#endif
+#endif  // NOTIFICATION_EX_EVENT_OBSERVER_INTERFACE_H_
index 2bdd2e3c7aa6eba8502b50d439909123f463a2be..dadfc6c6efe70e5dcdd52cf0c053ff7eba96a747 100644 (file)
@@ -19,6 +19,7 @@
 
 #include <bundle_cpp.h>
 
+#include <string>
 #include <list>
 
 #include "notification-ex/ievent_info.h"
index df8303463ec377847c014759851a2d1c0682ed44..afdc60b9801d389b816a42ab22448b804d1660f6 100644 (file)
@@ -40,7 +40,6 @@ class GroupItem::Impl {
   bool is_vertical_ = true;
   std::string app_label_;
   GroupItem* parent_;
-
 };
 
 }  // namespace item
index b34eb5078bf4bb74ef020a44589f3d0b30681f22..d0c746cfee08b8c24b44c631c01e907aa5e51a4d 100644 (file)
@@ -19,6 +19,8 @@
 
 #include <bundle_cpp.h>
 
+#include <string>
+
 namespace notification {
 
 #ifndef EXPORT_API
index 8f12d69b91df4ef024961d54848bcd1a782e1205..0cd035823ed2ee73b71c6db2627c9211367da5af 100644 (file)
@@ -49,4 +49,4 @@ class EXPORT_API IItemFactory {
 }  // namespace item
 }  // namespace notification
 
-#endif  // NOTIFICATION_EX_ITEM_FACTORY_H_
+#endif  // NOTIFICATION_EX_IITEM_FACTORY_H_
index f2dd10d1c1dc7a43ac8dfe4a6f6dc417948d3b7e..38edea46131477f97fe72ead41b767063c73a76e 100644 (file)
@@ -17,6 +17,9 @@
 #ifndef NOTIFICATION_EX_IITEM_INFO_INTERNAL_H_
 #define NOTIFICATION_EX_IITEM_INFO_INTERNAL_H_
 
+#include <string>
+#include <list>
+
 #include "notification-ex/iitem_info.h"
 
 #ifndef EXPORT_API
index 8cf60663b6a50948d3ca6b23079582f649bb62ea..490e32915dce02ab4148f64ebfd79738cc3188e6 100644 (file)
@@ -97,7 +97,7 @@ class EXPORT_API ImageItem : public AbstractItem {
  private:
   class Impl;
   std::unique_ptr<Impl> impl_;
-};  //class ImageItem
+};  // class ImageItem
 
 }  // namespace item
 }  // namespace notification
index 2325860fdbdd01b18bad74847bd1f9248455f3d8..e57d3a1abfb62088640e4896b799b91ad31be909 100644 (file)
@@ -61,14 +61,14 @@ class EXPORT_API InputSelectorItem : public AbstractItem {
    * @since_tizen 5.5
    * @return Bundle type data
    */
-  virtual tizen_base::Bundle Serialize() const override;
+  tizen_base::Bundle Serialize() const override;
 
   /**
    * @brief Deserialize the serialized data.
    * @since_tizen 5.5
    * @param[in] b The serialized Bundle data
    */
-  virtual void Deserialize(tizen_base::Bundle b) override;
+  void Deserialize(tizen_base::Bundle b) override;
 
   /**
    * @brief Checks the item type exist in this notification.
index db59895c488a8b4853ddeac2e42d2d5673e6e7f0..5f7497255fd68526486a5da9b1fb27c85d0f1cef 100644 (file)
@@ -32,7 +32,6 @@ namespace item {
  */
 class EXPORT_API ItemInflator {
  public:
-
   /**
    * @brief Creates AbstractItem from Bundle data
    * @since_tizen 5.5
index 90df35842d214472ed5eab2b7d44f5ab53708277..45257d9b9aceb3886b48b248a29cb0f0f13b8a54 100644 (file)
@@ -17,6 +17,9 @@
 #ifndef NOTIFICATION_EX_ITEM_INFO_INTERNAL_H_
 #define NOTIFICATION_EX_ITEM_INFO_INTERNAL_H_
 
+#include <string>
+#include <list>
+
 #include "notification-ex/abstract_item_implementation.h"
 #include "notification-ex/iitem_info_internal.h"
 
index 44cff3fa7d5eba2a7d7d0597715c27ecb0d5cacd..55148b386e38621adedd27946f8f73d366db9f56 100644 (file)
@@ -66,7 +66,6 @@ class EXPORT_API Manager : public IEventObserver {
  private:
   class Impl;
   std::unique_ptr<Impl> impl_;
-
 };
 
 }  // namespace notification
index 0db75501b68b285aaf08934b226674e42d57ae3f..adedb8a66032e80757c7f49444fdf5630a06045a 100644 (file)
@@ -75,14 +75,14 @@ class EXPORT_API ProgressItem : public AbstractItem {
    * @since_tizen 5.5
    * @return Bundle type data
    */
-  virtual tizen_base::Bundle Serialize() const override;
+  tizen_base::Bundle Serialize() const override;
 
   /**
    * @brief Deserialize the serialized data.
    * @since_tizen 5.5
    * @param[in] b The serialized Bundle data
    */
-  virtual void Deserialize(tizen_base::Bundle b) override;
+  void Deserialize(tizen_base::Bundle b) override;
 
   /**
    * @brief Checks the item type exist in this notification.
index 24040be605ac8249fabbc4854a33d76671e3c020..a244923adfd70df7c467fb42d264d18b66dca1e6 100644 (file)
@@ -1,5 +1,3 @@
-
-
 /*
  * Copyright (c) 2019 Samsung Electronics Co., Ltd.
  *
@@ -16,8 +14,8 @@
  * limitations under the License.
  */
 
-#ifndef NOTIFICATION_EX_INPUT_SELECTOR_ITEM_IMPLEMENTATION_H_
-#define NOTIFICATION_EX_INPUT_SELECTOR_ITEM_IMPLEMENTATION_H_
+#ifndef NOTIFICATION_EX_PROGRESS_ITEM_IMPLEMENTATION_H_
+#define NOTIFICATION_EX_PROGRESS_ITEM_IMPLEMENTATION_H_
 
 #include <string>
 #include <memory>
@@ -50,4 +48,4 @@ class ProgressItem::Impl {
 }  // namespace item
 }  // namespace notification
 
-#endif  // NOTIFICATION_EX_INPUT_SELECTOR_ITEM_IMPLEMENTATION_H_
+#endif  // NOTIFICATION_EX_PROGRESS_ITEM_IMPLEMENTATION_H_
index 45ab0b1ae70504cd23bda005408369bf2a300806..d5ca8a4bdb92df6229d3c92d0b22d75c2df938f4 100644 (file)
@@ -14,8 +14,8 @@
  * limitations under the License.
  */
 
-#ifndef NOTIFICATION_EX_REPOTER_H_
-#define NOTIFICATION_EX_REPOTER_H_
+#ifndef NOTIFICATION_EX_REPORTER_H_
+#define NOTIFICATION_EX_REPORTER_H_
 
 #include <string>
 #include <list>
@@ -68,4 +68,4 @@ class EXPORT_API Reporter : public IEventObserver {
 
 }  // namespace notification
 
-#endif  // NOTIFICATION_EX_REPOTER_H_
+#endif  // NOTIFICATION_EX_REPORTER_H_
index 74627ccc3d7ef89eb2824360fc70a47363796cc1..5b777589824a6f3065f63c081d7dbbd7431e3994 100644 (file)
@@ -150,7 +150,7 @@ class ManagerCallbackInfo {
     if (cb_.deleted == nullptr)
       return;
     IEventInfo* c_info = const_cast<IEventInfo*>(&info);
-    if(c_info->GetEventType() == static_cast<int>(IEventInfo::EventType::DeleteAll)) {
+    if (c_info->GetEventType() == static_cast<int>(IEventInfo::EventType::DeleteAll)) {
       cb_.deleted(static_cast<noti_ex_manager_h>(manager),
         static_cast<noti_ex_event_info_h>(c_info),
         nullptr, user_data_);
index 5139241ae7c46ddd50746cb92454c02f773f2b34..fadd3fc077215fae97824d9fd7bb7424a3bc8208 100644 (file)
@@ -45,7 +45,7 @@ class EXPORT_API TextItem : public AbstractItem {
    * @param[in] hyperlink The hyperlink of TextItem
    * @param[in] action The action for TextItem
    */
-  TextItem(std::string id ,std::string text,
+  TextItem(std::string idstd::string text,
       std::string hyperlink = std::string(),
       std::shared_ptr<AbstractAction> action = std::shared_ptr<AbstractAction>({}));
 
index 8855226c06a83d1b94f2049b8579627fc91be6cc..bb75681d17915976b870c98b7bc68679f2cc87e5 100644 (file)
@@ -17,6 +17,8 @@
 #ifndef NOTIFICATION_EX_VISIBILITY_ACTION_H_
 #define NOTIFICATION_EX_VISIBILITY_ACTION_H_
 
+#include <string>
+
 #include "notification-ex/abstract_action.h"
 
 namespace notification {
index d21479f09af7f8fe75147df9b26e6d2f08542796..9d73447656144fe0004f809920e67912cf488b17 100644 (file)
@@ -17,6 +17,7 @@
 #ifndef NOTIFICATION_EX_VISIBILITY_ACTION_IMPLEMENTATION_H_
 #define NOTIFICATION_EX_VISIBILITY_ACTION_IMPLEMENTATION_H_
 
+#include <string>
 #include <list>
 
 #include "notification-ex/visibility_action.h"
@@ -40,7 +41,7 @@ class VisibilityAction::Impl {
      VisibilityEntity(std::string id, bool visibility)
        : id_(id), visibility_(visibility) {
      }
-   };
+  };
 
  private:
   VisibilityAction* parent_;