fault-injection: make some stack filter attrs more readable
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 17 Aug 2022 08:03:31 +0000 (08:03 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 16 Dec 2022 00:40:44 +0000 (16:40 -0800)
Attributes of stack filter are show as unsigned decimal, such as
'require-start', 'require-end'.  This patch change to show them as
unsigned hexadecimal for more readable.

Before:
  $ echo 0xffffffffc0257000 > /sys/kernel/debug/failslab/require-start
  $ cat /sys/kernel/debug/failslab/require-start
  18446744072638263296

After:
  $ echo 0xffffffffc0257000 > /sys/kernel/debug/failslab/require-start
  $ cat /sys/kernel/debug/failslab/require-start
  0xffffffffc0257000

[wangyufen@huawei.com: use debugfs_create_xul() instead of debugfs_create_xl()]
Link: https://lkml.kernel.org/r/1664331299-4976-1-git-send-email-wangyufen@huawei.com
Link: https://lkml.kernel.org/r/20220817080332.1052710-4-weiyongjun1@huawei.com
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Isabella Basso <isabbasso@riseup.net>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/fault-inject.c

index fecc4d8..d7819ca 100644 (file)
@@ -226,10 +226,10 @@ struct dentry *fault_create_debugfs_attr(const char *name,
 #ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
        debugfs_create_stacktrace_depth("stacktrace-depth", mode, dir,
                                        &attr->stacktrace_depth);
-       debugfs_create_ul("require-start", mode, dir, &attr->require_start);
-       debugfs_create_ul("require-end", mode, dir, &attr->require_end);
-       debugfs_create_ul("reject-start", mode, dir, &attr->reject_start);
-       debugfs_create_ul("reject-end", mode, dir, &attr->reject_end);
+       debugfs_create_xul("require-start", mode, dir, &attr->require_start);
+       debugfs_create_xul("require-end", mode, dir, &attr->require_end);
+       debugfs_create_xul("reject-start", mode, dir, &attr->reject_start);
+       debugfs_create_xul("reject-end", mode, dir, &attr->reject_end);
 #endif /* CONFIG_FAULT_INJECTION_STACKTRACE_FILTER */
 
        attr->dname = dget(dir);