crypto: atmel-sha204a - Use device-managed registration API
authorChuhong Yuan <hslester96@gmail.com>
Tue, 23 Jul 2019 07:19:36 +0000 (15:19 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 2 Aug 2019 04:43:59 +0000 (14:43 +1000)
Use devm_hwrng_register to get rid of manual
unregistration.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/atmel-sha204a.c

index ea0d206..c96c14e 100644 (file)
@@ -109,7 +109,7 @@ static int atmel_sha204a_probe(struct i2c_client *client,
        i2c_priv->hwrng.read = atmel_sha204a_rng_read;
        i2c_priv->hwrng.quality = 1024;
 
-       ret = hwrng_register(&i2c_priv->hwrng);
+       ret = devm_hwrng_register(&client->dev, &i2c_priv->hwrng);
        if (ret)
                dev_warn(&client->dev, "failed to register RNG (%d)\n", ret);
 
@@ -127,7 +127,6 @@ static int atmel_sha204a_remove(struct i2c_client *client)
 
        if (i2c_priv->hwrng.priv)
                kfree((void *)i2c_priv->hwrng.priv);
-       hwrng_unregister(&i2c_priv->hwrng);
 
        return 0;
 }