media: iguanair: no superfluous usb_unlink_urb()
authorOliver Neukum <oneukum@suse.com>
Thu, 12 May 2022 12:50:00 +0000 (13:50 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 20 Jun 2022 09:30:33 +0000 (10:30 +0100)
Unlinking yourself while the completion handler
is running is a NOP. Drop it.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/rc/iguanair.c

index c9cb827..276bf3c 100644 (file)
@@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb)
                return;
 
        ir = urb->context;
-       if (!ir) {
-               usb_unlink_urb(urb);
+       if (!ir)
                return;
-       }
 
        switch (urb->status) {
        case 0:
@@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb)
        case -ECONNRESET:
        case -ENOENT:
        case -ESHUTDOWN:
-               usb_unlink_urb(urb);
                return;
        case -EPIPE:
        default: