Categorize PolicyBucketFixture unit tests

Categorize into positive/negative test cases.

Change-Id: Ic78e793e3d9d1ffe8e969f1f2054af2f83dc41ac

diff --git a/test/common/types/policybucket.cpp b/test/common/types/policybucket.cpp
index fff34c3d962fc24e54e11aa9fde10e8c98941b9f..816b21e1f86c97ffd080ab08bfb87db945693eaa 100644 (file)
--- a/test/common/types/policybucket.cpp
+++ b/test/common/types/policybucket.cpp
@@ -74,7 +74,7 @@ protected:
     };
 };
 
-TEST_F(PolicyBucketFixture, filtered) {
+TEST_F(PolicyBucketFixture, FilteredPositive) {
     using ::testing::UnorderedElementsAre;
 
     PolicyBucket bucket("filtered", pkPolicies);
@@ -88,7 +88,7 @@ TEST_F(PolicyBucketFixture, filtered) {
     ASSERT_EQ(PredefinedPolicyType::DENY, filtered.defaultPolicy());
 }
 
-TEST_F(PolicyBucketFixture, filtered_other) {
+TEST_F(PolicyBucketFixture, FilteredOtherPositive) {
     using ::testing::IsEmpty;
 
     PolicyBucket bucket("filtered_other", pkPolicies);
@@ -102,7 +102,7 @@ TEST_F(PolicyBucketFixture, filtered_other) {
     ASSERT_EQ(PredefinedPolicyType::DENY, filtered.defaultPolicy());
 }
 
-TEST_F(PolicyBucketFixture, filtered_wildcard_1) {
+TEST_F(PolicyBucketFixture, FilteredWildcard1Positive) {
     using ::testing::UnorderedElementsAreArray;
 
     // Leave policies with given client, given user and any privilege
@@ -113,7 +113,7 @@ TEST_F(PolicyBucketFixture, filtered_wildcard_1) {
     ASSERT_THAT(filtered, UnorderedElementsAreArray(policiesToStay));
 }
 
-TEST_F(PolicyBucketFixture, filtered_wildcard_2) {
+TEST_F(PolicyBucketFixture, FilteredWildcard2Positive) {
     using ::testing::UnorderedElementsAreArray;
 
     // Leave policies with given client, given user and any privilege
@@ -125,7 +125,7 @@ TEST_F(PolicyBucketFixture, filtered_wildcard_2) {
     ASSERT_THAT(filtered, UnorderedElementsAreArray(policiesToStay));
 }
 
-TEST_F(PolicyBucketFixture, filtered_wildcard_3) {
+TEST_F(PolicyBucketFixture, FilteredWildcard3Positive) {
     using ::testing::UnorderedElementsAreArray;
 
     // Leave policies with given client, given user and any privilege
@@ -136,7 +136,7 @@ TEST_F(PolicyBucketFixture, filtered_wildcard_3) {
     ASSERT_THAT(filtered, UnorderedElementsAreArray(policiesToStay));
 }
 
-TEST_F(PolicyBucketFixture, filtered_wildcard_4) {
+TEST_F(PolicyBucketFixture, FilteredWildcard4Positive) {
     using ::testing::UnorderedElementsAreArray;
 
     // Leave policies with given client, given user and any privilege
@@ -147,7 +147,7 @@ TEST_F(PolicyBucketFixture, filtered_wildcard_4) {
     ASSERT_THAT(filtered, UnorderedElementsAreArray(policiesToStay));
 }
 
-TEST_F(PolicyBucketFixture, filtered_wildcard_none) {
+TEST_F(PolicyBucketFixture, FilteredWildcardNonePositive) {
     using ::testing::IsEmpty;
 
     PolicyBucket bucket("filtered_wildcard_none",
@@ -163,7 +163,7 @@ TEST_F(PolicyBucketFixture, filtered_wildcard_none) {
  * - Iterate through vector of valid bucket ids and create them normally
  * - PolicyBucket constructor should not throw any exception
  */
-TEST_F(PolicyBucketFixture, bucket_id_validation_passes) {
+TEST_F(PolicyBucketFixture, BucketIdValidationPositive) {
     for (auto it = goodIds.begin(); it != goodIds.end(); ++it) {
         SCOPED_TRACE(*it);
         ASSERT_NO_THROW(PolicyBucket(PolicyBucketId(*it)));
@@ -176,7 +176,7 @@ TEST_F(PolicyBucketFixture, bucket_id_validation_passes) {
  * - Iterate through vector of bucket ids containing forbidden characters
  * - PolicyBucket constructor should throw an exception every time it is called
  */
-TEST_F(PolicyBucketFixture, bucket_id_validation_fails) {
+TEST_F(PolicyBucketFixture, BucketIdValidationNegative) {
     for (auto it = badIds.begin(); it != badIds.end(); ++it) {
         SCOPED_TRACE(*it);
         ASSERT_THROW(PolicyBucket(PolicyBucketId(*it)), InvalidBucketIdException);