Save coverage on beforeunload event

diff --git a/spec/coverage/reporter.js b/spec/coverage/reporter.js
index 0841f73..384e99f 100644 (file)
--- a/spec/coverage/reporter.js
+++ b/spec/coverage/reporter.js
@@ -63,31 +63,59 @@ exports.generateReport = () => {
   reporter.write(collector, true, function () {})
 }
 
-const saveCoverageData = (webContents, callback) => {
-  webContents.executeJavaScript('[global.__coverage__, global.process && global.process.pid]', function (results) {
+// Save coverage data from the browser window with the given pid
+const saveCoverageData = (coverage, pid) => {
+  if (coverage && pid) {
+    const dataPath = path.join(outputPath, 'data', `${pid}-${Date.now()}.json`)
+    mkdirp.sync(path.dirname(dataPath))
+    fs.writeFileSync(dataPath, JSON.stringify(coverage))
+  }
+}
+
+const getCoverageFromWebContents = (webContents, callback) => {
+  webContents.executeJavaScript('[global.__coverage__, global.process && global.process.pid]', (results) => {
     const coverage = results[0]
     const pid = results[1]
-    if (coverage && pid) {
-      const dataPath = path.join(outputPath, 'data', `${pid}-${Date.now()}.json`)
-      mkdirp.sync(path.dirname(dataPath))
-      fs.writeFileSync(dataPath, JSON.stringify(coverage, null, 2))
-      callback()
-    }
+    callback(coverage, pid)
   })
 }
 
-exports.setupCoverage = () => {
-  const coverage = global.__coverage__
-  if (coverage == null) return
-
-  rimraf.sync(path.join(outputPath, 'data'))
-
+// Save coverage data when a BrowserWindow is closed manually
+const patchBrowserWindow = () => {
   const {BrowserWindow} = require('electron')
 
-  const originalDestroy = BrowserWindow.prototype.destroy
+  const {destroy} = BrowserWindow.prototype
   BrowserWindow.prototype.destroy = function () {
-    saveCoverageData(this.webContents, () => {
-      originalDestroy.call(this)
+    if (this.isDestroyed()) return destroy.call(this)
+    getCoverageFromWebContents(this.webContents, (coverage, pid) => {
+      saveCoverageData(coverage, pid)
+      destroy.call(this)
     })
   }
 }
+
+// Save coverage data when beforeunload fires on the webContent's window object
+const saveCoverageOnBeforeUnload = () => {
+  const {app, ipcMain} = require('electron')
+
+  ipcMain.on('save-coverage', function (event, coverage, pid) {
+    saveCoverageData(coverage, pid)
+  })
+
+  app.on('web-contents-created', function (event, webContents) {
+    webContents.executeJavaScript(`
+      window.addEventListener('beforeunload', function () {
+        require('electron').ipcRenderer.send('save-coverage', global.__coverage__, process && process.pid)
+      })
+    `)
+  })
+}
+
+exports.setupCoverage = () => {
+  const coverage = global.__coverage__
+  if (coverage == null) return
+
+  rimraf.sync(path.join(outputPath, 'data'))
+  patchBrowserWindow()
+  saveCoverageOnBeforeUnload()
+}