Fix coverity (Incorrect deallocator used) defects

[Version] 0.12.60
[Issue Type] Vulnerability

Change-Id: Ia5ef3506a39748ebb12dc89e60917ec48f8f89b0

diff --git a/common/mm_sound_dbus.c b/common/mm_sound_dbus.c
index e6926f082682461583e1fb8436cb94c5d688636d..a8f964bda6eda2d2d6baf552ab777f7df3024732 100644 (file)
--- a/common/mm_sound_dbus.c
+++ b/common/mm_sound_dbus.c
@@ -448,7 +448,7 @@ int mm_sound_dbus_signal_subscribe_to(audio_provider_t provider, audio_event_t e
                return MM_ERROR_SOUND_INTERNAL;
        }
 
-       if (!(cb_data = (struct callback_data*)g_malloc0(sizeof(struct callback_data)))) {
+       if (!(cb_data = (struct callback_data*)g_try_malloc0(sizeof(struct callback_data)))) {
                debug_error("Allocate for callback data failed");
                return MM_ERROR_SOUND_INTERNAL;
        }
@@ -468,7 +468,7 @@ int mm_sound_dbus_signal_subscribe_to(audio_provider_t provider, audio_event_t e
        return MM_ERROR_NONE;
 
 fail:
-       free(cb_data);
+       g_free(cb_data);
        return MM_ERROR_SOUND_INTERNAL;
 }
 

diff --git a/packaging/libmm-sound.spec b/packaging/libmm-sound.spec
index 2d90f170b14fe36fd95cf6fb13c2c62b220beaf8..06487e459b85d9b6519ec51b3193519a1e3bec10 100644 (file)
--- a/packaging/libmm-sound.spec
+++ b/packaging/libmm-sound.spec
@@ -1,6 +1,6 @@
 Name:       libmm-sound
 Summary:    MMSound Package contains client lib and sound_server binary
-Version:    0.12.59
+Version:    0.12.60
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0