service: Do not allow service to be moved before a VPN service

This is needed as the default routes are not set properly
if we allow a service to be moved before a VPN service.

diff --git a/src/service.c b/src/service.c
index 7a62f3d..ea54a79 100644 (file)
--- a/src/service.c
+++ b/src/service.c
@@ -3284,7 +3284,8 @@ static DBusMessage *move_service(DBusConnection *conn,
                return __connman_error_not_supported(msg);
 
        target = find_service(path);
-       if (target == NULL || target->favorite == FALSE || target == service)
+       if (target == NULL || target->favorite == FALSE || target == service ||
+                               target->type == CONNMAN_SERVICE_TYPE_VPN)
                return __connman_error_invalid_service(msg);
 
        target4 = __connman_ipconfig_get_method(target->ipconfig_ipv4);