Staging: et131x: Fix warning of prefer ether_addr_copy() in et131x.c
authorMonam Agarwal <monamagarwal123@gmail.com>
Sat, 8 Mar 2014 14:23:07 +0000 (19:53 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Mar 2014 04:27:48 +0000 (20:27 -0800)
This patch fixes the following checkpatch.pl warnings:
WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)".
I used pahole to see whether addresses are aligned.

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/et131x/et131x.c

index cc600df..d329cf3 100644 (file)
@@ -3527,7 +3527,7 @@ static int et131x_pci_init(struct et131x_adapter *adapter,
                        goto err_out;
                }
        }
-       memcpy(adapter->addr, adapter->rom_addr, ETH_ALEN);
+       ether_addr_copy(adapter->addr, adapter->rom_addr);
 out:
        return rc;
 err_out:
@@ -3774,7 +3774,7 @@ static struct et131x_adapter *et131x_adapter_init(struct net_device *netdev,
        adapter->registry_jumbo_packet = 1514;  /* 1514-9216 */
 
        /* Set the MAC address to a default */
-       memcpy(adapter->addr, default_mac, ETH_ALEN);
+       ether_addr_copy(adapter->addr, default_mac);
 
        return adapter;
 }