Fix issue http://code.google.com/p/v8/issues/detail?id=58:

- Prevent a clipping of values when converting a double to an unsigned int
  for use as the random generator's seed value.
Review URL: http://codereview.chromium.org/1887

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@246 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/platform-linux.cc b/src/platform-linux.cc
index 9bac309c36c323d65f2435cc37dcd51457cca6f7..ba72768a7ceb02a156e04a13a4178bd3ac4a9a57 100644 (file)
--- a/src/platform-linux.cc
+++ b/src/platform-linux.cc
@@ -67,7 +67,12 @@ double ceiling(double x) {
 
 void OS::Setup() {
   // Seed the random number generator.
-  srandom(static_cast<unsigned int>(TimeCurrentMillis()));
+  // Convert the current time to a 64-bit integer first, before converting it
+  // to an unsigned. Going directly can cause an overflow and the seed to be
+  // set to all ones. The seed will be identical for different instances that
+  // call this setup code within the same millisecond.
+  uint64_t seed = static_cast<uint64_t>(TimeCurrentMillis());
+  srandom(static_cast<unsigned int>(seed));
 }
 
 

diff --git a/src/platform-macos.cc b/src/platform-macos.cc
index 5edd7a627410e9b9e8582b5f9d10543dedfeb21a..757312533580404e298420d4a63c3fe5cc0496f3 100644 (file)
--- a/src/platform-macos.cc
+++ b/src/platform-macos.cc
@@ -73,7 +73,12 @@ double ceiling(double x) {
 
 void OS::Setup() {
   // Seed the random number generator.
-  srandom(static_cast<unsigned int>(TimeCurrentMillis()));
+  // Convert the current time to a 64-bit integer first, before converting it
+  // to an unsigned. Going directly will cause an overflow and the seed to be
+  // set to all ones. The seed will be identical for different instances that
+  // call this setup code within the same millisecond.
+  uint64_t seed = static_cast<uint64_t>(TimeCurrentMillis());
+  srandom(static_cast<unsigned int>(seed));
 }
 
 

diff --git a/src/platform-win32.cc b/src/platform-win32.cc
index 2d54b6b870d68d09b7ac0cdada99849184a196b9..60354659d281f6eaa95f44daacbf162dd2d6d866 100644 (file)
--- a/src/platform-win32.cc
+++ b/src/platform-win32.cc
@@ -493,7 +493,12 @@ char* Time::LocalTimezone() {
 
 void OS::Setup() {
   // Seed the random number generator.
-  srand(static_cast<unsigned int>(TimeCurrentMillis()));
+  // Convert the current time to a 64-bit integer first, before converting it
+  // to an unsigned. Going directly can cause an overflow and the seed to be
+  // set to all ones. The seed will be identical for different instances that
+  // call this setup code within the same millisecond.
+  uint64_t seed = static_cast<uint64_t>(TimeCurrentMillis());
+  srand(static_cast<unsigned int>(seed));
 }