usb: gadget: uvc: configfs: Drop leaked references to config items

[ Upstream commit 86f3daed59bceb4fa7981d85e89f63ebbae1d561 ]

Some of the .allow_link() and .drop_link() operations implementations
call config_group_find_item() and then leak the reference to the
returned item. Fix this by dropping those references where needed.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c
index d7dcd39fe12cb76d7e5275b66646c79e0413c985..3803dda54666b9d4c57856a17d533299187e0841 100644 (file)
--- a/drivers/usb/gadget/function/uvc_configfs.c
+++ b/drivers/usb/gadget/function/uvc_configfs.c
@@ -543,6 +543,7 @@ static int uvcg_control_class_allow_link(struct config_item *src,
 unlock:
        mutex_unlock(&opts->lock);
 out:
+       config_item_put(header);
        mutex_unlock(su_mutex);
        return ret;
 }
@@ -584,6 +585,7 @@ static int uvcg_control_class_drop_link(struct config_item *src,
 unlock:
        mutex_unlock(&opts->lock);
 out:
+       config_item_put(header);
        mutex_unlock(su_mutex);
        return ret;
 }
@@ -2047,6 +2049,7 @@ static int uvcg_streaming_class_allow_link(struct config_item *src,
 unlock:
        mutex_unlock(&opts->lock);
 out:
+       config_item_put(header);
        mutex_unlock(su_mutex);
        return ret;
 }
@@ -2091,6 +2094,7 @@ static int uvcg_streaming_class_drop_link(struct config_item *src,
 unlock:
        mutex_unlock(&opts->lock);
 out:
+       config_item_put(header);
        mutex_unlock(su_mutex);
        return ret;
 }