mt76: mt7915: check for devm_pinctrl_get() failure
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 7 Mar 2022 14:13:49 +0000 (17:13 +0300)
committerFelix Fietkau <nbd@nbd.name>
Wed, 16 Mar 2022 16:40:22 +0000 (17:40 +0100)
If devm_pinctrl_get() fails then it leads to an error pointer
dereference.  Add a check to prevent that.

Fixes: 99ad32a4ca3a ("mt76: mt7915: add support for MT7986")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7915/soc.c

index 7698748..3028c02 100644 (file)
@@ -196,6 +196,8 @@ static int mt7986_wmac_gpio_setup(struct mt7915_dev *dev)
 
        type = mt7986_wmac_check_adie_type(dev);
        pinctrl = devm_pinctrl_get(dev->mt76.dev);
+       if (IS_ERR(pinctrl))
+               return PTR_ERR(pinctrl);
 
        switch (type) {
        case ADIE_SB: