pwm: zx: Add missing cleanup in error path
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 13 Oct 2020 08:13:21 +0000 (10:13 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:53:58 +0000 (11:53 +0100)
[ Upstream commit 269effd03f6142df4c74814cfdd5f0b041b30bf9 ]

zx_pwm_probe() called clk_prepare_enable() before; this must be undone
in the error path.

Fixes: 4836193c435c ("pwm: Add ZTE ZX PWM device driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-zx.c

index e2c21cc..3763ce5 100644 (file)
@@ -238,6 +238,7 @@ static int zx_pwm_probe(struct platform_device *pdev)
        ret = pwmchip_add(&zpc->chip);
        if (ret < 0) {
                dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);
+               clk_disable_unprepare(zpc->pclk);
                return ret;
        }