phy: ti: j721e-wiz: add missing of_node_put
authorJunlin Yang <yangjunlin@yulong.com>
Tue, 16 Feb 2021 08:27:39 +0000 (16:27 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 15 Mar 2021 10:05:32 +0000 (15:35 +0530)
Fix OF node leaks by calling of_node_put in
for_each_child_of_node when the cycle returns.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
Link: https://lore.kernel.org/r/20210216082739.1414-1-angkery@163.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-j721e-wiz.c

index c9cfafe..8a4be1e 100644 (file)
@@ -792,6 +792,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
                        dev_err(dev,
                                "%s: Reading \"reg\" from \"%s\" failed: %d\n",
                                __func__, subnode->name, ret);
+                       of_node_put(subnode);
                        return ret;
                }
                of_property_read_u32(subnode, "cdns,num-lanes", &num_lanes);