max17040_battery: Use devm_kzalloc
authorDevendra Naga <devendra.aaru@gmail.com>
Sun, 6 Jan 2013 04:53:25 +0000 (23:53 -0500)
committerAnton Vorontsov <anton@enomsg.org>
Sun, 6 Jan 2013 22:18:58 +0000 (14:18 -0800)
use devm_kzalloc and no need of error path and unload frees.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>
drivers/power/max17040_battery.c

index 22cfe9c..74a0bd9 100644 (file)
@@ -207,7 +207,7 @@ static int max17040_probe(struct i2c_client *client,
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE))
                return -EIO;
 
-       chip = kzalloc(sizeof(*chip), GFP_KERNEL);
+       chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
        if (!chip)
                return -ENOMEM;
 
@@ -225,7 +225,6 @@ static int max17040_probe(struct i2c_client *client,
        ret = power_supply_register(&client->dev, &chip->battery);
        if (ret) {
                dev_err(&client->dev, "failed: power supply register\n");
-               kfree(chip);
                return ret;
        }
 
@@ -244,7 +243,6 @@ static int max17040_remove(struct i2c_client *client)
 
        power_supply_unregister(&chip->battery);
        cancel_delayed_work(&chip->work);
-       kfree(chip);
        return 0;
 }