Remove "using namespace glu" from header

since this is a bad coding practise and can cause
issues when other files include it.

Affects: - (compilation only)
Component: OpenGL

Change-Id: I6809dcc7f0f12a9fde1b329889727708628798e3

diff --git a/external/openglcts/modules/common/glcSpirvUtils.cpp b/external/openglcts/modules/common/glcSpirvUtils.cpp
index ac2e9c2..b5aded3 100644 (file)
--- a/external/openglcts/modules/common/glcSpirvUtils.cpp
+++ b/external/openglcts/modules/common/glcSpirvUtils.cpp
@@ -42,6 +42,8 @@
 #include "spirv-tools/optimizer.hpp"
 #endif // DEQP_HAVE_SPIRV_TOOLS
 
+using namespace glu;
+
 namespace glc
 {
 

diff --git a/external/openglcts/modules/common/glcSpirvUtils.hpp b/external/openglcts/modules/common/glcSpirvUtils.hpp
index c6b2a7a..2ed596a 100644 (file)
--- a/external/openglcts/modules/common/glcSpirvUtils.hpp
+++ b/external/openglcts/modules/common/glcSpirvUtils.hpp
@@ -28,8 +28,6 @@
 #include <map>
 #include <vector>
 
-using namespace glu;
-
 namespace glc
 {
 typedef std::map<std::string, std::vector<std::string> > SpirVMapping;
@@ -39,11 +37,11 @@ namespace spirvUtils
 
 void checkGlSpirvSupported(deqp::Context& m_context);
 
-ShaderBinary makeSpirV(tcu::TestLog& log, ShaderSource source);
+glu::ShaderBinary makeSpirV(tcu::TestLog& log, glu::ShaderSource source);
 
-void spirvAssemble(ShaderBinaryDataType& dst, const std::string& src);
-void spirvDisassemble(std::string& dst, const ShaderBinaryDataType& src);
-bool spirvValidate(ShaderBinaryDataType& dst, bool throwOnError);
+void spirvAssemble(glu::ShaderBinaryDataType& dst, const std::string& src);
+void spirvDisassemble(std::string& dst, const glu::ShaderBinaryDataType& src);
+bool spirvValidate(glu::ShaderBinaryDataType& dst, bool throwOnError);
 
 bool verifyMappings(std::string glslSource, std::string spirVSource, SpirVMapping& mappings, bool anyOf);
 }