Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Feb 2012 16:57:45 +0000 (16:57 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Feb 2012 16:57:45 +0000 (16:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=78007

This got broken by: http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191

There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebKit/chromium:

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

26 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png
LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png
LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png
LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png
LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png
LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png
LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png
LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne.html
LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png
LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw.html
LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png
LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se.html
LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png
LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw.html
LayoutTests/platform/chromium/rubberbanding/overhang-e-expected.png
LayoutTests/platform/chromium/rubberbanding/overhang-n-expected.png
LayoutTests/platform/chromium/rubberbanding/overhang-ne-expected.png
LayoutTests/platform/chromium/rubberbanding/overhang-nw-expected.png
LayoutTests/platform/chromium/rubberbanding/overhang-s-expected.png
LayoutTests/platform/chromium/rubberbanding/overhang-se-expected.png
LayoutTests/platform/chromium/rubberbanding/overhang-sw-expected.png
LayoutTests/platform/chromium/rubberbanding/overhang-w-expected.png
LayoutTests/platform/chromium/test_expectations.txt
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/NonCompositedContentHost.cpp

index 7d92739..502d54a 100644 (file)
@@ -1,3 +1,18 @@
+2012-02-08  Alexei Svitkine  <asvitkine@chromium.org>
+
+        Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
+        https://bugs.webkit.org/show_bug.cgi?id=78007
+
+        This got broken by: http://trac.webkit.org/changeset/105470
+        And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191
+
+        There is still three tests that fail from the set, but the cause for these is different,
+        which I'm still investigating.
+
+        Reviewed by James Robinson.
+
+        * platform/chromium/test_expectations.txt:
+
 2012-02-08  Pavel Feldman  <pfeldman@google.com>
 
         Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
index 0806f8e..03c84e6 100644 (file)
Binary files a/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png and b/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png differ
index a371bf4..fd6df90 100644 (file)
Binary files a/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png and b/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png differ
index d3e0cda..cef6ade 100644 (file)
Binary files a/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png and b/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png differ
index ba9ba22..cdefb24 100644 (file)
Binary files a/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png and b/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png differ
index 5ab7a04..bd729cf 100644 (file)
Binary files a/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png and b/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png differ
index 8006937..7999d6e 100644 (file)
Binary files a/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png and b/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png differ
index 93777cb..912412d 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png and b/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png differ
index ca6208f..9102bc8 100644 (file)
@@ -11,7 +11,7 @@
         }
         ::-webkit-scrollbar-track-piece,
         ::-webkit-scrollbar-corner {
-            background-color: blue;
+            background-color: orange;
         }
     </style>
 </head>
index 05f76cb..67b08a2 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png and b/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png differ
index 1059760..88f2b6e 100644 (file)
@@ -11,7 +11,7 @@
         }
         ::-webkit-scrollbar-track-piece,
         ::-webkit-scrollbar-corner {
-            background-color: blue;
+            background-color: orange;
         }
     </style>
 </head>
index 9b0039a..d07d563 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png and b/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png differ
index 919cdf6..595d300 100644 (file)
@@ -11,7 +11,7 @@
         }
         ::-webkit-scrollbar-track-piece,
         ::-webkit-scrollbar-corner {
-            background-color: blue;
+            background-color: orange;
         }
     </style>
 </head>
index ceb6ee0..6cdc314 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png and b/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png differ
index 2d9ecd8..5def4ca 100644 (file)
@@ -11,7 +11,7 @@
         }
         ::-webkit-scrollbar-track-piece,
         ::-webkit-scrollbar-corner {
-            background-color: blue;
+            background-color: orange;
         }
     </style>
 </head>
index 3fc11ea..ff91657 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/overhang-e-expected.png and b/LayoutTests/platform/chromium/rubberbanding/overhang-e-expected.png differ
index 0806f8e..03c84e6 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/overhang-n-expected.png and b/LayoutTests/platform/chromium/rubberbanding/overhang-n-expected.png differ
index a371bf4..fd6df90 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/overhang-ne-expected.png and b/LayoutTests/platform/chromium/rubberbanding/overhang-ne-expected.png differ
index d3e0cda..cef6ade 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/overhang-nw-expected.png and b/LayoutTests/platform/chromium/rubberbanding/overhang-nw-expected.png differ
index 2ca92da..30d7af3 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/overhang-s-expected.png and b/LayoutTests/platform/chromium/rubberbanding/overhang-s-expected.png differ
index ef7d8e9..aa9b84d 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/overhang-se-expected.png and b/LayoutTests/platform/chromium/rubberbanding/overhang-se-expected.png differ
index 5ab7a04..bd729cf 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/overhang-sw-expected.png and b/LayoutTests/platform/chromium/rubberbanding/overhang-sw-expected.png differ
index 8006937..7999d6e 100644 (file)
Binary files a/LayoutTests/platform/chromium/rubberbanding/overhang-w-expected.png and b/LayoutTests/platform/chromium/rubberbanding/overhang-w-expected.png differ
index fc75d0c..baaa115 100644 (file)
@@ -517,9 +517,10 @@ WONTFIX SKIP : fast/frames/cross-site-this.html = FAIL
 // throw.  V8 follows the spec.
 WONTFIX SKIP : fast/js/reparsing-semicolon-insertion.html = FAIL
 
-// Rubber-banding is currently a CG only feature.
-WONTFIX : platform/chromium/rubberbanding = FAIL
-WONTFIX : platform/chromium/compositing/rubberbanding = IMAGE
+// These test rubber band overhang drawing, which is a Mac OS X Lion feature
+// that is not supported on other platforms.
+WONTFIX SKIP WIN LINUX : platform/chromium/rubberbanding = IMAGE
+WONTFIX SKIP WIN LINUX : platform/chromium/compositing/rubberbanding = IMAGE
 
 // This requires usp10.dll version 1.600 or greater on Windows and
 // it isn't installed on XP by default.
@@ -4042,6 +4043,10 @@ BUGWK77736 : svg/zoom/text/zoom-hixie-mixed-008.xml = IMAGE+TEXT
 BUGWK77736 MAC WIN : svg/zoom/text/zoom-hixie-mixed-009.xml = IMAGE
 BUGWK77736 : svg/zoom/text/zoom-hixie-rendering-model-004.xhtml = IMAGE+TEXT
 
+BUGWK78008 : platform/chromium/compositing/rubberbanding/transform-overhang-e.html = IMAGE
+BUGWK78008 : platform/chromium/compositing/rubberbanding/transform-overhang-se.html = IMAGE
+BUGWK78008 : platform/chromium/compositing/rubberbanding/transform-overhang-s.html = IMAGE
+
 // SVGLoad event timing changes require some rebaselines.
 BUGWK78084 : svg/custom/SVGPoint-matrixTransform.svg = IMAGE+TEXT
 BUGWK78084 : svg/custom/getTransformToElement.svg = IMAGE+TEXT
index 8b4d57e..37aa185 100644 (file)
@@ -1,3 +1,19 @@
+2012-02-08  Alexei Svitkine  <asvitkine@chromium.org>
+
+        Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
+        https://bugs.webkit.org/show_bug.cgi?id=78007
+
+        This got broken by: http://trac.webkit.org/changeset/105470
+        And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191
+
+        There is still three tests that fail from the set, but the cause for these is different,
+        which I'm still investigating.
+
+        Reviewed by James Robinson.
+
+        * src/NonCompositedContentHost.cpp:
+        (WebKit::NonCompositedContentHost::NonCompositedContentHost):
+
 2012-02-07  James Robinson  <jamesr@chromium.org>
 
         [chromium] Move geometry headers in Platform API to Platform directory
index 5f43a9a..c9be08a 100644 (file)
@@ -45,7 +45,9 @@ NonCompositedContentHost::NonCompositedContentHost(PassOwnPtr<WebCore::LayerPain
 #endif
     m_graphicsLayer->setDrawsContent(true);
     m_graphicsLayer->platformLayer()->setIsNonCompositedContent(true);
+#if !ENABLE(RUBBER_BANDING)
     m_graphicsLayer->platformLayer()->setBackgroundCoversViewport(true);
+#endif
     m_graphicsLayer->platformLayer()->setOpaque(true);
 }