gst-libs/gst/tag/gstvorbistag.c: Add comment about LANGUAGE tag inconsistency (we...

Original commit message from CVS:
* gst-libs/gst/tag/gstvorbistag.c: (gst_vorbis_tag_add):
Add comment about LANGUAGE tag inconsistency (we want
ISO-639-1, but extract three-letter identifiers?)
* po/POTFILES.in:
Add two translatable files.

diff --git a/ChangeLog b/ChangeLog
index d712616..0d97681 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,14 @@
 2006-02-05  Tim-Philipp Müller  <tim at centricular dot net>
 
+       * gst-libs/gst/tag/gstvorbistag.c: (gst_vorbis_tag_add):
+         Add comment about LANGUAGE tag inconsistency (we want
+         ISO-639-1, but extract three-letter identifiers?)
+
+       * po/POTFILES.in:
+         Add two translatable files.
+
+2006-02-05  Tim-Philipp Müller  <tim at centricular dot net>
+
        * gst-libs/gst/tag/Makefile.am:
        * gst-libs/gst/tag/gstvorbistag.c: (gst_vorbis_tag_add):
        * gst-libs/gst/tag/tag.h:

diff --git a/gst-libs/gst/tag/gstvorbistag.c b/gst-libs/gst/tag/gstvorbistag.c
index 0d00979..548d2d2 100644 (file)
--- a/gst-libs/gst/tag/gstvorbistag.c
+++ b/gst-libs/gst/tag/gstvorbistag.c
@@ -159,6 +159,10 @@ gst_vorbis_tag_add (GstTagList * list, const gchar * tag, const gchar * value)
       if (strcmp (tag, "LANGUAGE") == 0) {
         const gchar *s = strchr (value, '[');
 
+        /* FIXME: gsttaglist.h says our language tag contains ISO-639-1
+         * codes, which are 2 letter codes. The code below extracts 3-letter
+         * identifiers, which would be ISO-639-2. Mixup? Oversight? Wrong core
+         * docs? What do files in the wild contain? (tpm) */
         if (s && strchr (s, ']') == s + 4) {
           valid = g_strndup (s + 1, 3);
         }

diff --git a/po/POTFILES.in b/po/POTFILES.in
index a66d1cc..dc0ced5 100644 (file)
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -5,3 +5,5 @@ ext/gnomevfs/gstgnomevfssink.c
 ext/ogg/gstoggdemux.c
 gst/playback/gstplaybasebin.c
 gst/playback/gstplaybin.c
+gst-libs/gst/tag/tags.c
+gst-libs/gst/cdda/gstcddabasesrc.c