staging: r8188eu: cmd_seq is write-only

The cmd_seq component of struct cmd_priv is set and incremented but never
read. It can be removed.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
index 19b2f73d481dbc7f48513d8a75cda3437152570d..eb79435da355bef2902867c1360a2f9c0e08be23 100644 (file)
--- a/drivers/staging/r8188eu/core/rtw_cmd.c
+++ b/drivers/staging/r8188eu/core/rtw_cmd.c
@@ -65,8 +65,6 @@ int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)
 
        /* allocate DMA-able/Non-Page memory for cmd_buf and rsp_buf */
 
-       pcmdpriv->cmd_seq = 1;
-
        pcmdpriv->cmd_allocated_buf = kzalloc(MAX_CMDSZ + CMDBUFF_ALIGN_SZ,
                                              GFP_KERNEL);
 
@@ -233,8 +231,6 @@ _next:
                                ret = cmd_hdl(pcmd->padapter, pcmdbuf);
                                pcmd->res = ret;
                        }
-
-                       pcmdpriv->cmd_seq++;
                } else {
                        pcmd->res = H2C_PARAMETERS_ERROR;
                }

diff --git a/drivers/staging/r8188eu/include/rtw_cmd.h b/drivers/staging/r8188eu/include/rtw_cmd.h
index c330a4435b31a411887c5f0b7c2e9784dfb5590a..9df7d4bf441d1f0e926a1c0f9408a346b54b624a 100644 (file)
--- a/drivers/staging/r8188eu/include/rtw_cmd.h
+++ b/drivers/staging/r8188eu/include/rtw_cmd.h
@@ -32,7 +32,6 @@ struct cmd_priv {
        struct completion start_cmd_thread;
        struct completion stop_cmd_thread;
        struct __queue cmd_queue;
-       u8      cmd_seq;
        u8      *cmd_buf;       /* shall be non-paged, and 4 bytes aligned */
        u8      *cmd_allocated_buf;
        u8      *rsp_buf;       /* shall be non-paged, and 4 bytes aligned */